6.7.x #1221
Open
6.7.x #1221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modified the Image Plugin to: - add resize handles around image that allows to be resize via dragging them. - add 3 buttons to format the image to small ( 30% of original ), Best Fit ( 80% ) and Original size - ability to press delete/backspace and remove the image when it's selected - images are now inserted inline as base64. This prevents lots of viewing issues by remote parties that before had to load the image from a Group-Office URL
HtmlEditor Plugin that allows for the selection of Font Family & Font Size as ExtJS Combo Boxes. Lots of workarounds for getting the focus to go back to the editor after each selection change. Default font is Helvetica 14px which is what appears that GO was using by default
Create plugin for adding customizable & resizable tables. Tables can be resized via the blue square and deleted via the red square. The handles are only added to tables created in the current edit session
Major rewrite of the GO HtmlEditor component. Please note that our original code was based on version 6.7.78 which doesn't include this commit: Intermesh@9c3ef5c The main issue we tried solving was to have the most common buttons more readily available and visible, to have a proper functioning overflow menu in all window sizes and devices. The image button for example was added as a plugin but way too far to the right and not even visible in the Template Editor for example. We fixed all this by: - Removed some plugins like the wordpaste plugin, ssplugin, rmFormat. These in our experience were very rarely used if at all. Pasting from Word works great even without that plugin. - combining the B/I/U buttons as one and allowing them to be checked in order to apply the format and also to be updated depending on the cursor position. - moved the insert image button right after it - insert table/emojis are next - added realtime indicator of the font color. - removed all icons except font family/size B/I/U and insert image/emoijs from mobile devices. All other functions are spotty at best on mobile and I haven't seen other webmail to offer them. The main problem is returning the focus and inserting at the right place the various items/action. Group-Office overrides the ExtJS toolbar template with two spans, one for the icon, one for the text of the icon. But this doesn't play nice at all with the overflow menu which would show [Object object] since it was trying to show both icon and text. Lots of the code is just handling such small quirks.
Inserting the two new plugins
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added font family/size selection to HtmlEditor component.
Added insert table to HtmlEditor component
Added image resize wrappers & options
Moved images to inline source
Moved toolbar items around and fixed window overflow issues