Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zones protection integration #3067

Closed
wants to merge 3 commits into from

Conversation

T14D3
Copy link

@T14D3 T14D3 commented Jan 7, 2025

Overview

Add Zones region protection support

Description

Adds support for Zones as a protection plugin

Submitter Checklist

Preview Give feedback

@T14D3 T14D3 requested a review from a team as a code owner January 7, 2025 22:54
@github-actions github-actions bot added the Feature This PR adds a new feature label Jan 7, 2025
@PierreSchwang
Copy link
Member

I'm not really in favor adding support for a totally new plugin with 22 downloads. You are free to add the integration into Zones directly, so it hooks into FAWE - but adding it here adds maintenance burden for a (currently) very niche plugin.

@T14D3
Copy link
Author

T14D3 commented Jan 7, 2025

That's totally fair, figured I might as well go for it since it didn't require a lot of code changes so the maintenance needed is minimal to non-existent, but if that's a no I'll take it and look into hooking into FAWE - any resources to get me started on that?

@SirYwell
Copy link
Member

SirYwell commented Jan 8, 2025

That's totally fair, figured I might as well go for it since it didn't require a lot of code changes so the maintenance needed is minimal to non-existent, but if that's a no I'll take it and look into hooking into FAWE - any resources to get me started on that?

It's basically what you did already, just registering goes through the WEManager class, so something like WEManager.weManager().addManager(new ZonesFeature(zonePlugin)) (you obviously should check whether FAWE is present before calling that code).

@T14D3
Copy link
Author

T14D3 commented Jan 9, 2025

Thanks for your time, implemented on my end!

@T14D3 T14D3 closed this Jan 9, 2025
@T14D3 T14D3 deleted the feat/zones-integration branch January 9, 2025 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature This PR adds a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants