Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add permission to allow default nbt #3053

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat: add permission to allow default nbt #3053

wants to merge 2 commits into from
+31 −4

Conversation

dordsor21
Copy link
Member

@dordsor21 dordsor21 requested a review from a team as a code owner December 31, 2024 15:58
@github-actions github-actions bot added the Feature This PR adds a new feature label Dec 31, 2024
@PierreSchwang
Copy link
Member

Might it be possible to check for the permission first before comparing the nbt against the default state? I feel the later takes more resources and deep comparison (?)

@dordsor21
Copy link
Member Author

Probably. I also realised that this "breaks" current behaviour as I would say players with the current nbt permission should "inherit" the new one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Feature This PR adds a new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Suspicious sand NBT default state
2 participants
@dordsor21 @PierreSchwang