Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up some regen code #2405

Merged
merged 1 commit into from
Sep 9, 2023
Merged

Clean up some regen code #2405

merged 1 commit into from
Sep 9, 2023

Conversation

SirYwell
Copy link
Member

Overview

Description

This cleans up some

  • constant conditions
  • unused method parameters
  • use of Long where long can be used
  • typos
  • duplicated code

Submitter Checklist

Preview Give feedback

@SirYwell SirYwell requested a review from a team as a code owner August 21, 2023 12:19
@github-actions github-actions bot added the chore label Aug 21, 2023
@NotMyFault NotMyFault requested a review from a team August 23, 2023 07:21
@dordsor21 dordsor21 self-requested a review September 4, 2023 11:53
@NotMyFault NotMyFault merged commit 60a3994 into main Sep 9, 2023
@NotMyFault NotMyFault deleted the refactor/regen-cleanup branch September 9, 2023 14:07
@NanashiTheNameless
Copy link

this causes issues on 1.19.4 for me

@PierreSchwang
Copy link
Member

PierreSchwang commented Oct 22, 2023

this causes issues on 1.19.4 for me

Regeneration logic is currently completely rewritten. That issue would be solved then as well. If you want you can create an issue (if none matching exists yet) which can be closed by that change then. Therefor you will be actively notified when the error is fixed.

@SirYwell
Copy link
Member Author

I'm not sure how this would cause the issue, but if it worked before that, that's even more worrying. As it's a simple fix, I opened #2469.

@NanashiTheNameless
Copy link

I ended up cloning the latest version and reverted only the change to the Regen system manually and it worked again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants