Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated FindPythonLibs #1389

Conversation

ZzEeKkAa
Copy link
Contributor

@ZzEeKkAa ZzEeKkAa commented Sep 5, 2023

FindPythonLibs is deprecated since cmake 3.18 and was removed in cmake 3.27. It results in build errors for projects that uses 3.27 and dpctl.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
-- pybind11 v2.10.2
CMake Warning (dev) at _skbuild/linux-x86_64-3.11/cmake-build/_deps/pybind11-src/tools/FindPythonLibsNew.cmake:98 (find_package):
  Policy CMP0148 is not set: The FindPythonInterp and FindPythonLibs modules
  are removed.  Run "cmake --help-policy CMP0148" for policy details.  Use
  the cmake_policy command to set the policy and suppress this warning.

Call Stack (most recent call first):
  _skbuild/linux-x86_64-3.11/cmake-build/_deps/pybind11-src/tools/pybind11Tools.cmake:50 (find_package)
  _skbuild/linux-x86_64-3.11/cmake-build/_deps/pybind11-src/tools/pybind11Common.cmake:180 (include)
  _skbuild/linux-x86_64-3.11/cmake-build/_deps/pybind11-src/CMakeLists.txt:208 (include)
This warning is for project developers.  Use -Wno-dev to suppress it.

-- Found PythonInterp: /home/yevhenii/.miniconda3/envs/conda-build/bin/python (found suitable version "3.11.5", minimum required is "3.6")
-- Found PythonLibs: /home/yevhenii/.miniconda3/envs/conda-build/lib/libpython3.11.so
-- Performing Test HAS_INTEL_IPO
-- Performing Test HAS_INTEL_IPO - Success
CMake Warning (dev) at /home/yevhenii/.miniconda3/envs/conda-build/lib/python3.11/site-packages/skbuild/resources/cmake/FindPythonExtensions.cmake:245 (find_package):
  Policy CMP0148 is not set: The FindPythonInterp and FindPythonLibs modules
  are removed.  Run "cmake --help-policy CMP0148" for policy details.  Use
  the cmake_policy command to set the policy and suppress this warning.

Call Stack (most recent call first):
  dpctl/CMakeLists.txt:2 (find_package)
This warning is for project developers.  Use -Wno-dev to suppress it.

-- Found PythonInterp: /home/yevhenii/.miniconda3/envs/conda-build/bin/python (found version "3.11.5")
CMake Warning (dev) at /home/yevhenii/.miniconda3/envs/conda-build/lib/python3.11/site-packages/skbuild/resources/cmake/FindPythonExtensions.cmake:252 (find_package):
  Policy CMP0148 is not set: The FindPythonInterp and FindPythonLibs modules
  are removed.  Run "cmake --help-policy CMP0148" for policy details.  Use
  the cmake_policy command to set the policy and suppress this warning.

Call Stack (most recent call first):
  dpctl/CMakeLists.txt:2 (find_package)
This warning is for project developers.  Use -Wno-dev to suppress it.

But it looks like expected behavior: pybind/pybind11#4785

  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you opening the PR as a draft?

@ZzEeKkAa ZzEeKkAa marked this pull request as ready for review September 5, 2023 21:31
@diptorupd diptorupd changed the title Remove depricated FindPythonLibs Remove depecated FindPythonLibs Sep 5, 2023
Copy link
Collaborator

@oleksandr-pavlyk oleksandr-pavlyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ZzEeKkAa ZzEeKkAa changed the title Remove depecated FindPythonLibs Remove deprecated FindPythonLibs Sep 6, 2023
@ZzEeKkAa
Copy link
Contributor Author

ZzEeKkAa commented Sep 6, 2023

@oleksandr-pavlyk Thank you! I don't have an authority to merge the PR. Could you do it for me? Jenkins errors seems to be unrelated to the PR.

@oleksandr-pavlyk oleksandr-pavlyk merged commit 01e6c3d into IntelPython:master Sep 6, 2023
@ZzEeKkAa ZzEeKkAa mentioned this pull request Dec 6, 2023
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants