fix(dream11):unit tests in iOS #1278
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahmedAlaaInstabug
changed the title
a7medev
requested changes
Aug 21, 2024
There was a problem hiding this comment.
I don't think we need to include the changes from #1271 in this PR , let's just fix the tests with the current CI set up and it should fix it with the rest.
Also, let's not remove the Surveys bridge and return the removed surveys tests, having more discrepancies between master and dream11 will cause a lot of merge conflicts in the future.
a7medev
reviewed
Aug 21, 2024
| @@ -58,7 +58,7 @@ | |||
|
|
|||
| - (void)logVerbose:(NSString *)log; | |||
|
|
|||
| - (void)setReproStepsConfig: (IBGUserStepsMode)bugMode :(IBGUserStepsMode)crashMode:(IBGUserStepsMode)sessionReplayMode :(IBGUserStepsMode)anr :(IBGUserStepsMode)appHangsMode :(IBGUserStepsMode)fatalCrashMode :(IBGUserStepsMode)nonFatalCrashMode :(IBGUserStepsMode)forceRestartMode : (IBGUserStepsMode) oomMode; | |||
| - (void)setReproStepsConfig: (IBGUserStepsMode)bugMode :(IBGUserStepsMode)sessionReplayMode :(IBGUserStepsMode) anr :(IBGUserStepsMode)appHangsMode :(IBGUserStepsMode)fatalCrashMode :(IBGUserStepsMode)nonFatalCrashMode :(IBGUserStepsMode)forceRestartMode : (IBGUserStepsMode) oomMode ; | |||
There was a problem hiding this comment.
I think it'd be more readable if we put each parameter on a separate line and give them names rather than having all of them unnamed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
fix : unit test used files in dream11 branch
Type of change
Related issues
JIRA ID :
Checklists
Development
Code review