-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: ENH: Add script to migrate setup.py to pyproject.toml #161
base: main
Are you sure you want to change the base?
WIP: ENH: Add script to migrate setup.py to pyproject.toml #161
Conversation
Contains a few assumptions, but will generate a good starting point for most cases.
26e7619
to
448df20
Compare
Thanks for doing this Matt 💯. Gave it a try in InsightSoftwareConsortium/ITKTubeTK#162:
|
We will probably need additional steps to add the documentation dependencies, e.g. Also, we may need to warn users to add any additional dev or testing dependencies to |
template = template.replace('{{ cookiecutter.download_url }}', project_url) | ||
|
||
setup_dirname = os.path.dirname(setup_python_path) | ||
if os.path.exists(os.path.join(setup_dirname, 'README.md')): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Eventually, all README
files should be translated to either markdown or restructuredtext 🙃.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed. We could do this as a follow-up step.
@jhlegarreta thank you for the review and testing! I will knock some of these out next time I exercise the script. Feel free to push to this branch, though, if you have fixes. |
CC: @effigies |
rf: Patch setuptools/skbuild.setup() and extract exec'd metadata
Contains a few assumptions, but will generate a good starting point for most
cases.