[ENH] Allow anyone to create an application #769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CChemin
reviewed
Dec 23, 2022
sugoi-api-rest-services/src/test/resources/permissions/test-regexp-permissions.properties
Outdated
Show resolved
Hide resolved
CChemin
reviewed
Dec 23, 2022
sugoi-api-ldap-store-provider/src/main/java/fr/insee/sugoi/store/ldap/LdapStore.java
Outdated
Show resolved
Hide resolved
fjr3o6
force-pushed
the
675-sparkles-allow-anyone-to-create-an-application
branch
7 times, most recently
from
c5efa58
to
8cea996
Compare
CChemin
reviewed
Dec 30, 2022
| @@ -45,6 +45,7 @@ public class ApplicationServiceImpl implements ApplicationService { | |||
| public ProviderResponse create( | |||
| String realm, Application application, ProviderRequest providerRequest) { | |||
| try { | |||
|
|
|||
There was a problem hiding this comment.
est-ce que tu peux revert cette modif pour éviter d'avoir un changement inutile sur le fichier ?
CChemin
reviewed
Dec 30, 2022
sugoi-api-core/src/test/resources/permissions/test-regexp-permissions.properties
Outdated
Show resolved
Hide resolved
CChemin
reviewed
Dec 30, 2022
sugoi-api-core/src/test/java/fr/insee/sugoi/core/service/PermissionServiceTests.java
Outdated
Show resolved
Hide resolved
CChemin
reviewed
Dec 30, 2022
...tion/sugoi-api-distribution-full-env/src/main/resources/tomcat-properties/tomcat1.properties
Outdated
Show resolved
Hide resolved
CChemin
reviewed
Dec 30, 2022
...tion/sugoi-api-distribution-full-env/src/main/resources/tomcat-properties/tomcat2.properties
Outdated
Show resolved
Hide resolved
fjr3o6
force-pushed
the
675-sparkles-allow-anyone-to-create-an-application
branch
5 times, most recently
from
2efce80
to
c098377
Compare
Signed-off-by: Sommer Le <[email protected]>
CChemin
reviewed
Jan 13, 2023
| @@ -152,6 +152,10 @@ To learn more about this feature see : [Notify external webservices](concepts.md | |||
| | sugoi.api.event.webhook.mail.secondaryMailAttribute | Define the attribute where alternative mail for an user will be found | | secondaryMail | | |||
| | sugoi.api.event.webhook.enabled.events | List of events that will be sent by webhook event listener. The only accepted values are SEND_LOGIN, REINIT_PASSWORD and CHANGE_PASSWORD | SEND_LOGIN,REINIT_PASSWORD,CHANGE_PASSWORD | SEND_LOGIN,REINIT_PASSWORD | | |||
|
|
|||
| ### Application manager configuration | |||
|
|
|||
| | fr.insee.sugoi.api.regexp.role.application.creator | Default pattern to use when searching an application creator in a realm. Realm should be passed as$(realm). | no default | ROLE_SUGOI_$(realm)_APPLICATION_CREATOR | | |||
There was a problem hiding this comment.
il ne faut pas créer un nouveau paragraphe mais la mettre avec les configs similaire (par ex ligne 117)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Sommer Le [email protected]