New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor datepicker #744

Merged

laurentC35 merged 6 commits into 2.7 from ref/datepicker

Nov 2, 2023

Collaborator

Grafikart commented Oct 30, 2023 •

edited

Loading

Refactor of the datepicker component to use 3 number field instead of the native datepicker from the browser.

Behaviour

I tried to simulate the behaviour of the native datepicker :

When a field is focused, the whole text is selected to simplify input
If an invalid or incomplete date is entered, onChange is called with a null value (invalid or incomplete = no value)
Initial 0 are stripped since we use number input (we could switch to text input)
It supports the 3 format "YYYY-MM-DD", "YYYY-MM" and "YYYY"

Appearance

It's unstyled here since I don't load the lunatic CSS for this story.

Fix #141

Grafikart added 2 commits

October 30, 2023 14:49


          ref: datepicker multi fields

e638ce9


          fix: better story for datepicker

0ca6ec1

Grafikart changed the base branch from main to 2.7

October 30, 2023 14:20

laurentC35 added 2 commits

October 31, 2023 16:03


          style: add space for month & day

3029adb


          chore: remove useless import

5143c78

laurentC35 approved these changes

View reviewed changes

laurentC35 added 2 commits

November 2, 2023 10:01


          Merge branch '2.7' into ref/datepicker

76527aa


          fix: errors type in DatePicker

8d15d70

sonarcloud bot commented Nov 2, 2023

SonarCloud Quality Gate failed.

0 Bugs
0 Vulnerabilities
0 Security Hotspots
1 Code Smell

0.0% Coverage
0.0% Duplication

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

laurentC35 merged commit 91b049d into 2.7

15 of 16 checks passed

laurentC35 deleted the ref/datepicker branch

November 2, 2023 09:39

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet