Fix: GLOBAL_ITERATION_INDEX #726
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed! |
|
@Grafikart @laurentC35 I dont have any hindsight on the commits themselves but i could validate the behaviour with a dedicated storybook 😅 |
laurentC35
approved these changes
Oct 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When refactoring the variable system, the GLOBAL_ITERATION_INDEX support was removed.
Solution
When calculating a value in the new system, the variable GLOBAL_ITERATION_INDEX is intercepted and we assign the first iteration level inside (as an integer).
If GLOBAL_ITERATION_INDEX is used in a string it must be cast into a string
Fix #725
Fix #724