Tool to add MCM data on Tractography data #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ocommowi
force-pushed
the
master
branch
2 times, most recently
from
b3f19d7 to
afcf4f4
Compare
Florent2305
reviewed
Oct 4, 2023
| COMPONENT(DDI) \ | ||
|
|
||
| #define GENERATE_ENUM(ENUM) ENUM, | ||
| #define GENERATE_STRING(STRING) #STRING, |
There was a problem hiding this comment.
We must test this macro on MSVC.
| @@ -10,21 +10,30 @@ | |||
| #include <AnimaMCMBaseExport.h> | |||
| #include <animaMCMConstants.h> | |||
|
|
|||
| #define FOREACH_COMPONENT(COMPONENT) \ | |||
There was a problem hiding this comment.
Macros are in themselves a bit ugly, but in multi lines it's worse.
|
Thanks @Florent2305. This PR should actually not be merged yet. More work is needed following discussions with @jcoloigner who I invite to join the conversation here. I also think we should think of a better more consistent naming convention. Since it is primarily related to fibers the tool should be name starting with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New tool to add an interpolated MCM at each point of a collection of tracts.