Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to add a video to the Learning Path #564

Merged
merged 4 commits into from
Sep 19, 2023
Merged

Conversation

rrrutledge
Copy link
Contributor

No description provided.

@rrrutledge rrrutledge requested a review from nysenthil June 15, 2023 12:08
@rrrutledge rrrutledge requested a review from a team as a code owner June 15, 2023 12:08
Copy link
Member

@spier spier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if you needed a review of this but I left a comment inline :)

docs/upload-new-video.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@marshmallowrobot marshmallowrobot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rrrutledge This makes it sound so easy to add a new video!

Copy-edit-wise: Please capitalize the title.

Content-wise, two things:

  1. As the resident subtitler, I would really love it if we asked content creators to add their own subtitles to their videos. It is my hope that this will result in videos where the host enunciates, and speaks more slowly. What do you think? If you agree, could you maybe add that as a blurb to the end of the list?
  2. Regarding @spier's point about granting access to the channel, could that be added somewhere too?

@rrrutledge
Copy link
Contributor Author

Thanks, @marshmallowrobot ! Will take a look.

@rrrutledge
Copy link
Contributor Author

OK @marshmallowrobot take a look.

@rrrutledge rrrutledge merged commit 3351580 into main Sep 19, 2023
@rrrutledge rrrutledge deleted the rrrutledge-patch-2 branch September 19, 2023 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants