-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Scheduled sending #1619
base: master
Are you sure you want to change the base?
feat: Scheduled sending #1619
Conversation
Found 1 unused code occurences Expand
|
3e2cb04
to
3b6959a
Compare
aaf5e1f
to
b657e94
Compare
4af1490
to
821485e
Compare
Quality Gate passedIssues Measures |
"editSendDescription" = "Programmation annulée. Ce message sera déplacé dans vos brouillons pour être envoyé quand vous le souhaitez."; | ||
|
||
/* loco:6723a9b2b22031bf3701ae62 */ | ||
"editSendTitle" = "Modifier l’envoie"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
envoi
@@ -802,6 +832,9 @@ | |||
/* loco:649424a6e244ffcc6c011135 */ | |||
"errorRefusedSender" = "Le serveur refuse l’expéditeur"; | |||
|
|||
/* loco:672900a15da35624510b2c32 */ | |||
"errorScheduleTooShort" = "Le délai minimum est de 5 minutes."; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"errorScheduleTooShort" = "Le délai minimum est de 5 minutes."; | |
"errorScheduleDelayTooShort" = "Le délai minimum est de 5 minutes."; |
Text(MailResourcesStrings.Localizable.datePickerTitle) | ||
.textStyle(.bodyMedium) | ||
.padding(.bottom, IKPadding.alertTitleBottom) | ||
DatePicker("", selection: $selectedDate, in: Date.minimumScheduleDelay...) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Even if we don't show it, the label is used by the accessibility reader
private func modifySchedule() { | ||
Task { | ||
await mailboxManager.moveScheduleToDraft(draftResource: draftResource) | ||
if let draft = await mailboxManager.loadRemotely(from: draftResource) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use guard
|
||
DraftUtils.editDraft(from: message, mailboxManager: mailboxManager, composeMessageIntent: composeMessageIntent) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Revert
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use the existing one with yellow stars
This PR introduces the Scheduled Send feature to the kMail iOS app, allowing users to schedule emails to be sent at a later time.
Key Changes