Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(PhotoSync): Do not start if not enough free space available #1385

Merged
merged 3 commits into from
Jan 17, 2025

Conversation

adrien-coye
Copy link
Contributor

@adrien-coye adrien-coye commented Jan 16, 2025

Here is what it looks like in the rare event of not enough space before we try to launch a sync.

This is important for iCloud users, as we will be unable to fetch iCloud assets if there is no sufficient space on the device.

Screenshot 2025-01-16 at 18 38 45

@adrien-coye adrien-coye added the bug Something isn't working label Jan 16, 2025
@adrien-coye adrien-coye added this to the 5.0.3 milestone Jan 16, 2025
@adrien-coye adrien-coye changed the title feat: Photo sync do not start if not enough free space availlable fix: Photo sync do not start if not enough free space availlable Jan 16, 2025
@adrien-coye adrien-coye changed the title fix: Photo sync do not start if not enough free space availlable fix(PhotoSync): do not start if not enough free space availlable Jan 16, 2025
@PhilippeWeidmann PhilippeWeidmann changed the title fix(PhotoSync): do not start if not enough free space availlable fix(PhotoSync): Do not start if not enough free space available Jan 17, 2025
@adrien-coye adrien-coye enabled auto-merge January 17, 2025 11:53
@adrien-coye adrien-coye force-pushed the photo-sync-check-free-space branch from 1bf0ffb to 3fd0265 Compare January 17, 2025 11:54
@adrien-coye adrien-coye changed the title fix(PhotoSync): Do not start if not enough free space available fix(PhotoSync): Do not start if not enough free space available Jan 17, 2025
@adrien-coye adrien-coye merged commit b3bd8a7 into master Jan 17, 2025
6 of 7 checks passed
@adrien-coye adrien-coye deleted the photo-sync-check-free-space branch January 17, 2025 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants