fix(HomeLastPicCollectionViewCell): Refresh during multi selection deselects all #1371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e cell during its configuration
|
adrien-coye
commented
Jan 2, 2025
| @@ -94,7 +99,8 @@ class HomeLastPicCollectionViewCell: UICollectionViewCell { | |||
| contentInsetView.cornerRadius = UIConstants.cornerRadius | |||
| } | |||
| videoData.isHidden = !(file.uti.conforms(to: .video) || file.uti.conforms(to: .movie)) | |||
| configureForSelection() | |||
|
|
|||
| self.isSelected = isSelected | |||
There was a problem hiding this comment.
Setting it will call configureForSelection on didSet
adrien-coye
commented
Jan 2, 2025
| @@ -31,6 +31,10 @@ class HomeLastPicCollectionViewCell: UICollectionViewCell { | |||
| private var thumbnailDownloadTask: Kingfisher.DownloadTask? | |||
|
|
|||
| override var isSelected: Bool { | |||
| willSet { | |||
| // NOTE: DifferenceKit reset the selected flag mid air. Investigating | |||
| print("•• isSelected changed: \(newValue) fid:\(file?.id)") | |||
There was a problem hiding this comment.
diffKit will set to false after the configuration of the cell, disabling it.
I'm still looking for an elegant fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explicit the selected state of the cell during its configuration