Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(PhotoLibraryUploader): Early photo upload start. #1354

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

adrien-coye
Copy link
Contributor

@adrien-coye adrien-coye commented Dec 13, 2024

Start the upload during a photo sync after the scan of the first batch of pictures.
Strictly limited to foreground app operations.

@adrien-coye adrien-coye marked this pull request as draft December 13, 2024 18:14
@adrien-coye adrien-coye changed the title fix(PhotoLibrary): Early photo start fix(PhotoLibraryUploader): Early photo start. Dec 13, 2024
@adrien-coye adrien-coye changed the title fix(PhotoLibraryUploader): Early photo start. fix(PhotoLibraryUploader): Early photo upload start. Dec 13, 2024
@adrien-coye adrien-coye added the bug Something isn't working label Dec 16, 2024
@adrien-coye adrien-coye marked this pull request as ready for review January 6, 2025 13:55
Copy link

sonarqubecloud bot commented Jan 6, 2025

@adrien-coye adrien-coye added feature A new functionality is added to the product and removed bug Something isn't working labels Jan 7, 2025
@adrien-coye adrien-coye marked this pull request as draft January 7, 2025 08:15
@adrien-coye
Copy link
Contributor Author

If the upload starts before the initial scan is performed, it can become flaky.
The trivial patch is not sufficient as is, moved to Draft again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature A new functionality is added to the product
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant