feat: External links famous last five percent #1349
Draft
+742
−403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 tasks
adrien-coye
changed the title
adrien-coye
commented
Dec 10, 2024
kDrive/UI/Controller/Files/File List/FileListViewController.swift
Outdated
Show resolved
Hide resolved
adrien-coye
force-pushed
the
externalLinks-famousLastFivePercent
branch
from
bf43649 to
93bbb8e
Compare
adrien-coye
commented
Dec 11, 2024
adrien-coye
commented
Dec 11, 2024
| } | ||
| } | ||
|
|
||
| DownloadQueue.instance.addPublicShareToQueue(file: currentDirectory, | ||
| driveFileManager: driveFileManager, | ||
| publicShareProxy: publicShareProxy) | ||
| } | ||
|
|
||
| private func addToMyDrive(sender: Any?, publicShareProxy: PublicShareProxy) { | ||
| let selectedItemsIds = multipleSelectionViewModel?.selectedItems.map(\.id) ?? [] + [rootProxy.id] |
There was a problem hiding this comment.
add rootProxy.id only if not root
…d register code to be able to use it from elsewhere. feat: UpsaleViewController actions are performing the auth actions like expected.
adrien-coye
force-pushed
the
externalLinks-famousLastFivePercent
branch
from
28552a8 to
fa0097e
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature PR #1306
Making sure to link the last details together.