Bug fix: setProgress should not exit with an error when the item progress is not managed. #374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… error when the item progress is not managed.
|
ClementKunz
approved these changes
Nov 5, 2024
herve-er
deleted the
KDESKTOP-1340-ProgressInfo-setProgress-should-not-fail-on-omited-operation
branch
| @@ -140,7 +142,9 @@ bool ProgressInfo::setProgressComplete(const SyncPath &path, const SyncFileStatu | |||
|
|
|||
| const auto it = _currentItems.find(normalizedPath); | |||
There was a problem hiding this comment.
The two blocks looks identical. Refactoring to remove redundancy would let us write a fix in a single place.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, calling ProgressInfo::setProgress on an item that is not in the _currentItems list returns an error. It should instead behave as if !shouldCountProgress and return successfully.
This is problematic in the case of omitted operations, which will systematically generate an error. This error prevent us to correctly set the vfs and status of the file.