JsonParserUtility::extractValue ensure to not return garbage value #359
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR, if the key was not found or was found but empty, the
JsonParserUtility::extractValue
method would return true and leave theval
variable unchanged.This behavior caused issues in the following scenario:
If
symbolicLinkKey
was not found,tmpStr
would retain the value offileTypeKey
, mistakenly treating the item as a link by assuming the link URL was not empty.This PR modifies
extractValue
to clear theval
variable when the key is not found, preventing this unintended behavior.