Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KDESKTOP-1305-File-path-not-found-in-Executor #353

Merged
merged 5 commits into from
Oct 18, 2024
Merged

KDESKTOP-1305-File-path-not-found-in-Executor #353

merged 5 commits into from
Oct 18, 2024

Conversation

ClementKunz
Copy link
Contributor

There is still an issue wioth NFD encoding in Executor

@ClementKunz ClementKunz self-assigned this Oct 17, 2024
@ClementKunz ClementKunz requested a review from a team as a code owner October 17, 2024 10:52
luc-guyot-infomaniak
luc-guyot-infomaniak reviewed Oct 17, 2024
View reviewed changes
Copy link
Contributor

@luc-guyot-infomaniak luc-guyot-infomaniak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Any unit test for initProgress or setProgress?

@ClementKunz ClementKunz added the not scheduled in current sprint The fix is ready but was not planned label Oct 17, 2024
@ClementKunz
Copy link
Contributor Author

Looks good. Any unit test for initProgress or setProgress?

I didn't. Done in 0a2ed75

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@ClementKunz ClementKunz merged commit c740c66 into develop Oct 18, 2024
6 checks passed
@ClementKunz ClementKunz deleted the KDESKTOP-1305-File-path-not-found-in-Executor branch October 18, 2024 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luc-guyot-infomaniak luc-guyot-infomaniak luc-guyot-infomaniak approved these changes

Assignees

@ClementKunz ClementKunz

Labels
not scheduled in current sprint The fix is ready but was not planned
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ClementKunz @luc-guyot-infomaniak