Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kdesktop 1260 Fix a crash when we fail to create a VFS. #345

Merged
merged 4 commits into from
Oct 10, 2024
Merged

Kdesktop 1260 Fix a crash when we fail to create a VFS. #345

merged 4 commits into from
Oct 10, 2024

Conversation

herve-er
Copy link
Contributor

@herve-er herve-er commented Oct 9, 2024

No description provided.

@herve-er herve-er requested a review from a team as a code owner October 9, 2024 13:39
@herve-er herve-er changed the title Kdesktop 1260 remove nullptr from vfs map when unable to create vfs Kdesktop 1260 Fix a crash when we fail to create a VFS. Oct 9, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 10, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
2 Security Hotspots
0.0% Coverage on New Code (required ≥ 80%)
E Reliability Rating on New Code (required ≥ A)
C Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@ClementKunz ClementKunz merged commit 1e2be13 into develop Oct 10, 2024
5 of 6 checks passed
@ClementKunz ClementKunz deleted the KDESKTOP-1260-Remove-nullptr-from-_vfsMap-when-unable-to-create-VFS branch October 10, 2024 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChristopheLarchier ChristopheLarchier ChristopheLarchier approved these changes

Assignees

@herve-er herve-er

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@herve-er @ChristopheLarchier @ClementKunz