Merge branch 'KDESKTOP-1359-Vfs-functions-should-return-an-ExitInfo' of

https://github.com/Infomaniak/desktop-kDrive into KDESKTOP-1359-Vfs-functions-should-return-an-ExitInfo
Infomaniak · Dec 12, 2024 · 529b11a · 529b11a
2 parents d8750cd + 7e1ed53
commit 529b11a
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 6 deletions.
diff --git a/src/libcommon/log/sentry/abstractcounterscopedptrace.h b/src/libcommon/log/sentry/abstractcounterscopedptrace.h
@@ -40,7 +40,7 @@ class AbstractCounterScopedPTrace : public AbstractScopedPTrace {
             AbstractScopedPTrace(info, PTraceStatus::Cancelled, syncDbId), _nbOfCyclesPerTrace(nbOfCyclePerTrace) {}
 
     private:
-        void stop(PTraceStatus status = PTraceStatus::Ok) final {
+        void stop([[maybe_unused]] PTraceStatus status = PTraceStatus::Ok) final {
             assert(false && "stop() should not be called with CounterScopedPTrace.");
         }
         void restart() final {

diff --git a/src/libcommon/log/sentry/ptraces.h b/src/libcommon/log/sentry/ptraces.h
@@ -24,11 +24,14 @@
 namespace KDC::sentry::pTraces {
 
 struct None : public AbstractPTrace {
-        None() = default;
-        None(int syncdbId) : AbstractPTrace({}, syncdbId) {}
-        void start() final {}
-        void stop(PTraceStatus status = PTraceStatus::Ok) final {}
-        void restart() final {}
+        None() : AbstractPTrace({}){};
+        explicit None(int syncdbId) : AbstractPTrace({}, syncdbId) {}
+        void start() final { /* Do nothing */
+        }
+        void stop([[maybe_unused]] PTraceStatus status = PTraceStatus::Ok) final { /* Do nothing */
+        }
+        void restart() final { /* Do nothing */
+        }
 };
 
 /*