Protect against empty range in selection #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
valentinperignon
approved these changes
Jun 10, 2024
LunarX
force-pushed
the
secure-get-selection
branch
2 times, most recently
from
29165cb to
2c670fc
Compare
LunarX
force-pushed
the
secure-get-selection
branch
2 times, most recently
from
3eb9d7b to
fd8e3f8
Compare
KevinBoulongne
approved these changes
Jun 19, 2024
|
This PR/issue depends on:
|
When the webview doesn't have focus, there's no range to get so simply abort the operation instead of throwing an error
LunarX
force-pushed
the
secure-get-selection
branch
from
fd8e3f8 to
f221413
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the webview doesn't have focus, there's no range to get so simply abort the operation instead of throwing an error
Depends on #2