Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detail error when permission validation error occurs #2767

Merged
merged 5 commits into from
Nov 20, 2024

Conversation

akhilmhdh
Copy link
Member

Description 📣

This PR brings support to helping users understand the error better when permission fails. Right now when validation error occurs it shows failure message as usual with a show morebutton.

With that a modal will be shown in which there rule is set. Likewise a detail one for forbidden error

Screenshot 2024-11-20 at 10 39 15 PM

Type ✨

  • Bug fix
  • New feature
  • Improvement
  • Breaking change
  • Documentation

Tests 🛠️

# Here's some code block to paste some code snippets

Copy link
Contributor

@scott-ray-wilson scott-ray-wilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Nice work! Please review my commit, welcome to merge if that looks good to you

@akhilmhdh akhilmhdh merged commit 90057d8 into Infisical:main Nov 20, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants