Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamic secret commands in CLI #2740

Merged
merged 4 commits into from
Nov 27, 2024

Conversation

akhilmhdh
Copy link
Member

Description 📣

This PR brings support to dynamic secret commands in CLI. Primarily secret list, lease list, renew,revoke and create. Root credentials management is something to be on ui side then cli side at the moment

Updated docs as well a tiny bug in backend too.
Screenshot 2024-11-15 at 8 26 00 PM

Type ✨

  • Bug fix
  • New feature
  • Improvement
  • Breaking change
  • Documentation

Tests 🛠️

# Here's some code block to paste some code snippets

@akhilmhdh akhilmhdh self-assigned this Nov 15, 2024
Copy link
Collaborator

@maidul98 maidul98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

haven't reviewed this fully yet but if this data is displayed as a table how are we expecting scripts to parse this data? (this is how users want to make use of this)

Copy link
Contributor

@DanielHougaard DanielHougaard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good work! left a few comments

cli/packages/visualize/dynamic_secret_leases.go Outdated Show resolved Hide resolved
cli/packages/cmd/dynamic_secret.go Outdated Show resolved Hide resolved
cli/packages/visualize/visualize.go Outdated Show resolved Hide resolved
docs/cli/commands/dynamic-secrets.mdx Outdated Show resolved Hide resolved
docs/cli/commands/dynamic-secrets.mdx Show resolved Hide resolved
cli/packages/cmd/dynamic_secret.go Outdated Show resolved Hide resolved
cli/packages/cmd/dynamic_secret.go Outdated Show resolved Hide resolved
@akhilmhdh akhilmhdh merged commit 84ff71f into Infisical:main Nov 27, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants