-
Notifications
You must be signed in to change notification settings - Fork 988
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dynamic secret commands in CLI #2740
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
haven't reviewed this fully yet but if this data is displayed as a table how are we expecting scripts to parse this data? (this is how users want to make use of this)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good work! left a few comments
Description 📣
This PR brings support to dynamic secret commands in CLI. Primarily secret list, lease list, renew,revoke and create. Root credentials management is something to be on ui side then cli side at the moment
Updated docs as well a tiny bug in backend too.
Type ✨
Tests 🛠️
# Here's some code block to paste some code snippets