Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add offchain input and state, and add SingleOffchainSigner #22

Merged
merged 9 commits into from
Oct 15, 2024
Merged

feat: Add offchain input and state, and add SingleOffchainSigner #22

merged 9 commits into from
Oct 15, 2024

Conversation

MaanavKhaitan
Copy link
Collaborator

@MaanavKhaitan MaanavKhaitan commented Oct 14, 2024 •
edited
Loading

What

  • Adds support for onchain input / offchain input / state in contracts and rust zkVM code
  • Adds OffchainResultWithMetadata struct to contracts
  • Adds SingleOffchainSigner interface
  • Replaces ethos references with InfinityVM

Testing

cargo build && forge test -vvv --ffi: Passes

@MaanavKhaitan MaanavKhaitan changed the title feat: Update to latest version of contracts feat: Add offchain input and state, and add SingleOffchainSigner Oct 15, 2024
@MaanavKhaitan MaanavKhaitan marked this pull request as ready for review October 15, 2024 03:49
lucasege
lucasege approved these changes Oct 15, 2024
View reviewed changes
Copy link
Contributor

@lucasege lucasege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, largely looks like many things pulled in from upstream InfinityVM so it seems good to me

@MaanavKhaitan MaanavKhaitan merged commit b897697 into main Oct 15, 2024
5 checks passed
@MaanavKhaitan MaanavKhaitan deleted the maanav/update-template branch October 15, 2024 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucasege lucasege lucasege approved these changes

@emostov emostov Awaiting requested review from emostov

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MaanavKhaitan @lucasege