add allowedSymlinks option #117
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Misterio77
force-pushed
the
push-plwvsqorwkzt
branch
from
074a188 to
81bb92f
Compare
|
Test case added, and ready to go! |
Misterio77
force-pushed
the
push-plwvsqorwkzt
branch
2 times, most recently
from
e9964e8 to
81bb92f
Compare
Misterio77
force-pushed
the
push-plwvsqorwkzt
branch
from
81bb92f to
e8406c7
Compare
Infinidoge
requested changes
Dec 29, 2024
| @@ -449,6 +457,24 @@ in | |||
| ''; | |||
| }; | |||
|
|
|||
| allowedSymlinks = mkOption { | |||
| default = ["/nix/store"]; | |||
There was a problem hiding this comment.
Rather than setting this as a default, it should instead be added as part of config. Otherwise, it leads to the unintuitive behavior of adding to allowedSymlinks removing /nix/store from the list. Removing /nix/store should require lib.mkForce.
There was a problem hiding this comment.
You're totally right. I'll get that fixed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #92.
txt format cherry picked from #103 (thanks @arminius-smh!)