Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(extension): Add AaveMigrationExtension #162

Merged
merged 8 commits into from
Feb 22, 2024

Conversation

pblivin0x
Copy link
Contributor

No description provided.

@pblivin0x pblivin0x changed the title feat(extension): Add AaveMigrationExtension feat(extension): Add AaveMigrationExtension Feb 21, 2024
@coveralls
Copy link

coveralls commented Feb 21, 2024

Coverage Status

coverage: 75.981% (-1.6%) from 77.572%
when pulling 6cc5172 on aave-migration-extension
into f780e9c on master.

@pblivin0x pblivin0x marked this pull request as ready for review February 21, 2024 22:49
@pblivin0x pblivin0x requested review from ckoopmann and edkim February 21, 2024 22:49
Copy link
Collaborator

@ckoopmann ckoopmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM: Just minor nits.
Agree with keeping tick calculation off chain for simplicity.
Great work💪

contracts/adapters/AaveMigrationExtension.sol Outdated Show resolved Hide resolved
contracts/adapters/AaveMigrationExtension.sol Show resolved Hide resolved
contracts/adapters/AaveMigrationExtension.sol Outdated Show resolved Hide resolved
contracts/adapters/AaveMigrationExtension.sol Outdated Show resolved Hide resolved
contracts/adapters/AaveMigrationExtension.sol Outdated Show resolved Hide resolved
contracts/adapters/AaveMigrationExtension.sol Outdated Show resolved Hide resolved
@pblivin0x pblivin0x requested a review from ckoopmann February 22, 2024 03:09
Copy link
Collaborator

@ckoopmann ckoopmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Good stuff 👍

@pblivin0x pblivin0x merged commit f1d2baf into master Feb 22, 2024
9 checks passed
@pblivin0x pblivin0x deleted the aave-migration-extension branch February 22, 2024 03:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants