feat: add swap quote provider protocol #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janndriessen
commented
May 22, 2024
janndriessen
commented
May 22, 2024
src/quote/swap/adapters/zeroex.ts
Outdated
| sellTokenAddress: string | ||
| } | ||
|
|
||
| export class ZeroExSwapQuoteProvider implements SwapQuoteProvider { |
There was a problem hiding this comment.
Essentially, it's the same class as the ZeroExApi only adapted to the protocol.
janndriessen
commented
May 22, 2024
src/quote/swap/adapters/zeroex.ts
Outdated
| } | ||
|
|
||
| return params | ||
| } |
There was a problem hiding this comment.
This is new converting the swap quote request to the zero ex api swap request.
janndriessen
commented
May 22, 2024
janndriessen
commented
May 22, 2024
| } else { | ||
| params.inputAmount = sellAmount.toString() | ||
| } | ||
| const quotePromise = swapQuoteProvider.getSwapQuote(params) |
There was a problem hiding this comment.
Using the new SwapQuoteRequest inside this components quote provider which is an essential part of the FlashMintZeroEx provider.
janndriessen
commented
May 22, 2024
janndriessen
commented
May 22, 2024
janndriessen
commented
May 22, 2024
janndriessen
commented
May 22, 2024
janndriessen
commented
May 22, 2024
janndriessen
force-pushed
the
feat/add-swap-quote-provider-protocol
branch
from
e138319 to
1f413b6
Compare
feat: add swap quote interface
feat: add v3
feat: use rpc url
feat: remove 0x utils
feat: add 0x swap data
feat: enhance quote return
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SwapQuoteProviderprotocol making getting quotes more modular by being able to input any desired adapter to handle the swap quotes.Closes #51