Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds the app tree to the controller overview #258

Merged
merged 32 commits into from
Dec 10, 2024
Merged

Adds the app tree to the controller overview #258

merged 32 commits into from
Dec 10, 2024

Conversation

dalonsoa
Copy link
Collaborator

@dalonsoa dalonsoa commented Dec 3, 2024

Description

Adds the application tree to the controller overview page, as well as the required functions to retrieve the information from the backend.

NOTE: Ignore the lock. The issue it was meant to fixed is being fixed properly in #263 and will be incorporated into this one when merged.

Screen.Recording.2024-12-03.at.16.36.31.mov

Fixes #228
Fixes #163

Type of change

  • Documentation (non-breaking change that adds or improves the documentation)
  • New feature (non-breaking change which adds functionality)
  • Optimization (non-breaking, back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (whatever its nature)

Key checklist

  • All tests pass (eg. python -m pytest)
  • The documentation builds and looks OK (eg. python -m sphinx -b html docs docs/build)
  • Pre-commit hooks run successfully (eg. pre-commit run --all-files)

Further checks

  • Code is commented, particularly in hard-to-understand areas
  • Tests added or an issue has been opened to tackle that in the future. (Indicate issue here: # (issue))

@dalonsoa dalonsoa requested review from cc-a, jamesturner246 and AdrianDAlessandro and removed request for cc-a and jamesturner246 December 3, 2024 16:45
@AdrianDAlessandro
Copy link
Contributor

Can you change the target branch of this PR to fsm_dialog?

@dalonsoa dalonsoa changed the base branch from main to fsm_dialog December 3, 2024 17:22
@dalonsoa
Copy link
Collaborator Author

dalonsoa commented Dec 3, 2024

Done! Sorry for the mistake

@dalonsoa
Copy link
Collaborator Author

dalonsoa commented Dec 3, 2024

I also forgot to upload the screen recording 🤦‍♂️ Will do first thing tomorrow morning.

@codecov-commenter
Copy link

codecov-commenter commented Dec 3, 2024

Codecov Report

Attention: Patch coverage is 82.35294% with 12 lines in your changes missing coverage. Please review.

Project coverage is 86.49%. Comparing base (5df30d7) to head (18704e4).
Report is 33 commits behind head on fsm_dialog.

Files with missing lines Patch % Lines
process_manager/process_manager_interface.py 16.66% 5 Missing ⚠️
controller/controller_interface.py 85.18% 4 Missing ⚠️
controller/views/partials.py 71.42% 2 Missing ⚠️
controller/views/pages.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff               @@
##           fsm_dialog     #258      +/-   ##
==============================================
- Coverage       86.76%   86.49%   -0.28%     
==============================================
  Files              38       39       +1     
  Lines             544      607      +63     
==============================================
+ Hits              472      525      +53     
- Misses             72       82      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dalonsoa dalonsoa changed the title Tree Adds the app tree to the controller overview Dec 4, 2024
Copy link
Contributor

@cc-a cc-a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. Just a few refinements needed.

controller/views/partials.py Outdated Show resolved Hide resolved
controller/controller_interface.py Show resolved Hide resolved
controller/templates/controller/partials/app_tree.html Outdated Show resolved Hide resolved
@dalonsoa dalonsoa linked an issue Dec 5, 2024 that may be closed by this pull request
2 tasks
@dalonsoa dalonsoa requested a review from cc-a December 5, 2024 11:39
Copy link
Contributor

@cc-a cc-a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff. One more on the stack.

Copy link
Contributor

@AdrianDAlessandro AdrianDAlessandro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once the threading lock is removed

Copy link
Contributor

@jamesturner246 jamesturner246 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, besides needing local copies of the js and css.

I understand a lot of this will change in #262.

controller/templates/controller/index.html Show resolved Hide resolved
@cc-a cc-a merged commit 67a2935 into fsm_dialog Dec 10, 2024
4 checks passed
@cc-a cc-a deleted the tree branch December 10, 2024 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement front end side of things in the application tree summary Summary application tree
5 participants