-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds the app tree to the controller overview #258
Conversation
Can you change the target branch of this PR to |
Done! Sorry for the mistake |
I also forgot to upload the screen recording 🤦♂️ Will do first thing tomorrow morning. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## fsm_dialog #258 +/- ##
==============================================
- Coverage 86.76% 86.49% -0.28%
==============================================
Files 38 39 +1
Lines 544 607 +63
==============================================
+ Hits 472 525 +53
- Misses 72 82 +10 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good. Just a few refinements needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great stuff. One more on the stack.
Use 1x1 config as default session
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM once the threading lock is removed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, besides needing local copies of the js and css.
I understand a lot of this will change in #262.
Adds the tree table page
Description
Adds the application tree to the controller overview page, as well as the required functions to retrieve the information from the backend.
NOTE: Ignore the lock. The issue it was meant to fixed is being fixed properly in #263 and will be incorporated into this one when merged.
Screen.Recording.2024-12-03.at.16.36.31.mov
Fixes #228
Fixes #163
Type of change
Key checklist
python -m pytest
)python -m sphinx -b html docs docs/build
)pre-commit run --all-files
)Further checks