osmnx bug

[barneydobson]

Description

They changed bbox definition in different osmnx versions..

Not sure if this is the most robust way to do this but seems fine?

Type of change

• Documentation (non-breaking change that adds or improves the documentation)
• New feature (non-breaking change which adds functionality)
• Optimization (non-breaking, back-end change that speeds up the code)
• Bug fix (non-breaking change which fixes an issue)
• Breaking change (whatever its nature)

Key checklist

• All tests pass (eg. python -m pytest)
• The documentation builds and looks OK (eg. python -m sphinx -b html docs docs/build)
• Pre-commit hooks run successfully (eg. pre-commit run --all-files)

Further checks

• Code is commented, particularly in hard-to-understand areas
• Tests added or an issue has been opened to tackle that in the future. (Indicate issue here: # (issue))

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 14.28571% with 6 lines in your changes missing coverage. Please review.

Project coverage is 87.54%. Comparing base (dcda446) to head (ff5d059).
Report is 4 commits behind head on main.

Files with missing lines	Patch %	Lines
src/swmmanywhere/prepare_data.py	14.28%	4 Missing and 2 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #346      +/-   ##
==========================================
- Coverage   87.79%   87.54%   -0.25%     
==========================================
  Files          22       22              
  Lines        2220     2224       +4     
  Branches      280      282       +2     
==========================================
- Hits         1949     1947       -2     
- Misses        194      198       +4     
- Partials       77       79       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[cheginit]

The bbox option was added to osmnx since version 1.9.0. So, you can just set the min version of osmnx in swmmanywhere to 1.9 and use bbox everywhere, instead of adding a new dep (packaging).

[barneydobson]

OK RE using bbox but they changed the order of coordinates in their bbox arg in 2.0.0b1 (from the strange NSEW to conventional WSEN), which is what the check is for

[dalonsoa]

That's a very annoying breaking change from osmnx side, but I guess that's what major versions are for.