Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add test cli #333

Merged
merged 9 commits into from
Oct 25, 2024
Merged

add test cli #333

merged 9 commits into from
Oct 25, 2024

Conversation

barneydobson
Copy link
Collaborator

@barneydobson barneydobson commented Oct 23, 2024

Description

Test cli

Fixes #182

Type of change

  • Documentation (non-breaking change that adds or improves the documentation)
  • New feature (non-breaking change which adds functionality)
  • Optimization (non-breaking, back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (whatever its nature)

Key checklist

  • All tests pass (eg. python -m pytest)
  • The documentation builds and looks OK (eg. python -m sphinx -b html docs docs/build)
  • Pre-commit hooks run successfully (eg. pre-commit run --all-files)

Further checks

  • Code is commented, particularly in hard-to-understand areas
  • Tests added or an issue has been opened to tackle that in the future. (Indicate issue here: # (issue))

@codecov-commenter
Copy link

codecov-commenter commented Oct 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.77%. Comparing base (b5779c1) to head (2cf15a2).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #333      +/-   ##
==========================================
+ Coverage   86.91%   87.77%   +0.85%     
==========================================
  Files          22       22              
  Lines        2217     2217              
  Branches      280      280              
==========================================
+ Hits         1927     1946      +19     
+ Misses        214      194      -20     
- Partials       76       77       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@barneydobson barneydobson requested a review from dalonsoa October 24, 2024 11:56
Copy link
Collaborator

@dalonsoa dalonsoa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just a minor suggeestion.

tests/test_cli.py Outdated Show resolved Hide resolved
barneydobson and others added 2 commits October 25, 2024 13:53
Co-authored-by: Diego Alonso Álvarez <[email protected]>
@barneydobson barneydobson merged commit 00719d3 into main Oct 25, 2024
5 checks passed
@barneydobson barneydobson deleted the test-cli branch October 25, 2024 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CLI testing
3 participants