Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename modules #29

Merged
merged 5 commits into from
Jan 26, 2024
Merged

Rename modules #29

merged 5 commits into from
Jan 26, 2024

Conversation

barneydobson
Copy link
Collaborator

Description

  • Rename downloaders -> prepare_data
  • Rename geospatial_operations -> utils_geo
  • Update imports and tests

Dobson added 3 commits January 26, 2024 09:08
Rename
4a455c0 
-downloaders->prepare_data (and in imports)
-geospatial_operations->utils_geo (and in imports)
Rename utils_geo and prepare_data tests
317d7d0
Create prepare_data and utils_geo
3eb965d
@barneydobson barneydobson requested a review from dalonsoa January 26, 2024 09:24
dalonsoa
dalonsoa approved these changes Jan 26, 2024
View reviewed changes
Copy link
Collaborator

@dalonsoa dalonsoa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Not a huge fan of shortening module names, though, but totally up to you. Why not geospatial_utilities, in full? You're probably going to shorten its name when in use, anyway.

@barneydobson
Copy link
Collaborator Author

suits me - I tend towards verbosity with naming!

@barneydobson barneydobson merged commit 0dc06ff into main Jan 26, 2024
10 checks passed
@barneydobson barneydobson deleted the rename_modules branch January 26, 2024 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dalonsoa dalonsoa dalonsoa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@barneydobson @dalonsoa