Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fractional segmentation #161

Merged
merged 10 commits into from
Nov 28, 2024
Merged

Conversation

pedrokohler
Copy link
Collaborator

Fixing fractional segmentations:
1 - fixing color palette and maintaining transparent background
2 - removing color palette overlay for binary segmentations
3 - removing annoying zoom when activating segmentations

Addresses: ImagingDataCommons/slim#245

Binary segmentation now = no background and no color palette overlay:
image

Fractional segmentation now = no background and proper colors:
image

@pedrokohler
Copy link
Collaborator Author

@fedorov please check the PR description and let me know if that's all

@fedorov
Copy link
Member

fedorov commented Nov 24, 2024

@pedrokohler nice work! Good to go from the description and the screenshot, once @igoroctaviano approves it!

@fedorov
Copy link
Member

fedorov commented Nov 24, 2024

Small nitpick - is it possible to include min and max pixel values in the color palette overlay for fractional?

@pedrokohler
Copy link
Collaborator Author

pedrokohler commented Nov 25, 2024

Small nitpick - is it possible to include min and max pixel values in the color palette overlay for fractional?

@fedorov what do you mean exactly?

@fedorov
Copy link
Member

fedorov commented Nov 25, 2024

I mean that right now it is impossible to tell what values the extreme colors (deep purple and yellow) correspond to. I mean, I assume blue is zero and yellow is 255? But we can also refine it separately. Another related suggestion is to allow showing the actual value in a tooltip on mouse over, on on click, as we do for binary. It is ok to do both of those outside of this PR.

@pedrokohler
Copy link
Collaborator Author

@fedorov is this good enough?
image

@fedorov
Copy link
Member

fedorov commented Nov 25, 2024

Yes!

@fedorov
Copy link
Member

fedorov commented Nov 26, 2024

@pedrokohler when this is merged, can you please update dmv version in Slim, and then propagate updates from Slim into idc-slim repo https://github.com/ImagingDataCommons/idc-slim?

src/viewer.js Show resolved Hide resolved
src/viewer.js Outdated Show resolved Hide resolved
src/viewer.js Show resolved Hide resolved
Copy link
Collaborator

@igoroctaviano igoroctaviano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pedrokohler
Copy link
Collaborator Author

@fedorov @igoroctaviano whoever has access, please merge. I'm not authorized.

@igoroctaviano igoroctaviano merged commit 309f9c8 into master Nov 28, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants