-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fractional segmentation #161
Conversation
@fedorov please check the PR description and let me know if that's all |
@pedrokohler nice work! Good to go from the description and the screenshot, once @igoroctaviano approves it! |
Small nitpick - is it possible to include min and max pixel values in the color palette overlay for fractional? |
@fedorov what do you mean exactly? |
I mean that right now it is impossible to tell what values the extreme colors (deep purple and yellow) correspond to. I mean, I assume blue is zero and yellow is 255? But we can also refine it separately. Another related suggestion is to allow showing the actual value in a tooltip on mouse over, on on click, as we do for binary. It is ok to do both of those outside of this PR. |
@fedorov is this good enough? |
Yes! |
@pedrokohler when this is merged, can you please update dmv version in Slim, and then propagate updates from Slim into idc-slim repo https://github.com/ImagingDataCommons/idc-slim? |
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@fedorov @igoroctaviano whoever has access, please merge. I'm not authorized. |
Fixing fractional segmentations:
1 - fixing color palette and maintaining transparent background
2 - removing color palette overlay for binary segmentations
3 - removing annoying zoom when activating segmentations
Addresses: ImagingDataCommons/slim#245
Binary segmentation now = no background and no color palette overlay:
Fractional segmentation now = no background and proper colors: