Refactoring and resolution of performance issues #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* New resources module
* New methods module
* New API structure
* New FilterConfig, GraphStore, Colours GridSpecStore and ExtractedData classes
extending an Immutable type (once set, cannot be changed)
* ExtractedData class is comparable
* DataExtractor class moved to resources
* DataExtractor now works on a merge table rather than generated indexes
* Improved API Documentation
* Added Tests for core functionality
* Improved lint checks
Full write-up of changes can be found in docs/WhatChanged-Version2.md
Differences in output.
* The histogram plot show slightly different values to
the original library. This could be for one of 2 reasons.
1. An issue with selecting the results into ExtractedData
objects.
2. The original library plotted incorrect results potentially
including NaN as a value. This would have provided larger
datasets than the re-work which explicitly deletes NaN
values.
mproffitt
force-pushed
the
feature/ISSUE-7-Severe-Performance-Degradation
branch
from
c01fa0e
to
97aefda
Compare
* Added reset method to change index on small dataframes
* Frames are now merged in on a copy with the column names on the original frame reset post merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request implements a new API and resolves ISSUE-7 - Severe Performance Degradation when working with large data-sets.
A full breakdown of the changes provided is available at https://github.com/mproffitt/py-upset/blob/feature/ISSUE-7-Severe-Performance-Degradation/docs/WhatChanged-Version2.md with a discussion on performance towards the bottom.
Synopsis of changes
pyupset.__init__exposes only theplot()function,visualisation.UpsetPlot,resources.FilterConfig,resources.DataExtractorclasses andresources.SortMethodsEnum