Integration of ImPlot, ImNodes and ImGuizmo #218

TillAlex · 2020-11-28T22:20:24Z

This PR adds support for ImPlot(#191), ImNodes(#201) and ImGuizmo(#200).

What has been done:

Added ImPlot.NET, ImNodes.NET and ImGuizmo.NET projects
Modified CodeGenerator to generate code for cimplot, cimnodes and cimguizmo
Added definition files from cimplot, cimnodes and cimguizmo
Added ImPlot demo window to sample program

Until now I only did minimal testing. Binaries including cimplot, cimnodes and cimguizmo are missing. For testing I manually compiled a cimgui.dll including cimplot. I am not sure if you prefer one binary including all projects or separate binaries.

Please let me know what you think about this PR. Feel free to change this PR in any way that is necessary to include it. If you need me to change anything let me know.

…tion

…ding definition files

mellinoe · 2020-11-29T06:30:44Z

This is fantastic stuff, thanks for putting this together @TillAlex. I definitely want to support this in some form, and in general most of the changes here look reasonable.

One question is how the native portions should be organized and delivered. As far as I can tell, all of these libraries are intended to be compiled and included together in a single native DLL. That's obviously possible here as well based on your testing, but it would be better if we could separate them out into 4 dynamic libraries (libcimgui, libimplot, libimnodes, and libimguizmo). This would allow users of ImGui.NET alone to avoid including extra libraries that they aren't interested in.

The new libraries would need to be built against a particular version of libcimgui (and thus would need to be used w/ a particular version of ImGui.NET), but I can't think of any technical reason why this wouldn't work. Functionally, this would mean expanding ImGui.NET-nativebuild to cover the new libraries, in a way that produced 4 compatible dynamic libs from source.

Long-term, I'd like to see the extra libraries moved out of this repo into separate ones, but I don't feel very strongly about that initially. The fact that all of them will need CodeGenerator means that a larger restructuring would be needed for that to work. Along these lines, it would be nice if CodeGenerator was a little less aware of the quirks of each individual project (e.g. now it knows about things like ImPlotContext specifically). CodeGenerator is filled with its fair share of hacks, a lot of this could probably be cleaned up and fixed at the same time. It would be great if CodeGenerator could be used as a utility for any cimgui-based library without needing tons of modifications to it.

mellinoe

The changes to CodeGenerator are relatively minor, so I don't have any major issues with them. I would like to see CodeGenerator made more generic (e.g. instead of hard-coding all of these new quirks, it would be better if they were passed in somehow), but it's a larger piece of work. To get this merged, I think we should work towards the following:

Get the end-to-end working w/ the native libraries. We can set up an auto-build of some other branch of ImGui.NET-nativebuild to test this before incorporating it into the main branch there. The new C# projects should include those native libraries exactly the same way that ImGui.NET does.
Trim the additions down to just ImPlot and ImGuizmo. It turns out that there are 3 similar node editor extensions (imnodes, ImNodes, and imgui-node-editor). The latter seems to have the largest usage (judging by activity), but I don't think there's a cimgui binding for it. I don't really want to be in the business of choosing which one of those to support here. Long-term, I'd like all of this to live outside of the main repository here (including any future libraries that users want to wrap) so someone else could support it if they wanted. I'm okay with including ImPlot and ImGuizmo to prove this out for now.

src/CodeGenerator/Program.cs

mellinoe · 2020-11-29T06:48:22Z

src/CodeGenerator/TypeInfo.cs

+
+        public static readonly List<string> WellKnownEnums = new List<string>()
+        {
+            "ImGuiMouseButton"


Hm, I guess this is needed because one of the new projects uses ImGuiMouseButton, but the definitions.json file that is used for it doesn't include it (since it's part of cimgui). This might work as a quick fix, but it points to a deeper issue. It seems like the new libraries should reference the cimgui definitions while generating code.

mellinoe · 2020-11-29T06:51:24Z

src/ImGuizmo.NET/Generated/MODE.gen.cs

@@ -0,0 +1,8 @@
+namespace ImGuiNET
+{
+    public enum MODE


I was a bit conflicted above, but seeing some of these types makes me think that these new libraries should be in their own namespaces. I don't necessarily want types like MODE and OPERATION to pollute the ImGuiNET namespace for regular users of ImGui.NET even if they have to opt-in to this library.

mellinoe · 2020-11-29T07:07:58Z

src/CodeGenerator/Program.cs

+            {
+                "cimgui" => "ImGui",
+                "cimplot" => "ImPlot",
+                "cimnodes" => "ImNodes",


After looking into this more, cimnodes actually wraps the imnodes project, which is similar but different to another project called ImNodes. Using ImNodes as the class name (instea of imnodes) might be confusing because of that.

TillAlex · 2020-11-29T11:41:28Z

Thanks for your comments!

On 1) I think you are totally right that split native libraries are the better solution and it shouldn't be to complicated to integrate that into ImGui.NET-nativebuild. I am not a cmake pro, but I will give it a try.

On 2) I understand your point about ImNodes, but I also think it's sad not to have a nodes editor for ImGui.NET. Perhaps we should just generate wrappers for all the cimxxx projects so that the user can choose from at least two of the three nodes editors. If @sonoro1234 decides to include imgui-node-editor as well we can add that as well.

Hopefully I will find some time this evening to work on some of the points from your comments.

cbaal83 · 2020-11-29T11:50:11Z

Hi Alex,
could you please provide your pre-build native libs? I would love to test this but don't want to spent to much time on building the native libs :).

Best regards,
//cbaal

TillAlex · 2020-11-29T23:19:05Z

@cbaal83 Here are x64 binaries I just built: binaries.zip

Included are separate binaries of the current versions of cimgui, cimplot, cimnodes and cimguizmo. I changed this PR to work with these. Until now I only tested the demo window of ImPlot used in ImGui.NET.SampleProgram. It works as long as you replace the original cimgui with the one in the zip, because cimplot.dll is built against ImGui 1.79.

I am not sure if my way of building separate binaries is correct. Let me know if they work for you.

…izmo_Integration # Conflicts: # src/ImGui.NET.SampleProgram/ImGui.NET.SampleProgram.csproj

cbaal83 · 2020-11-30T08:35:16Z

@TillAlex
Thank you very much! Will test today! If something is buggy i will post it here.
//cbaal

cbaal83 · 2020-11-30T08:53:47Z

at ImGuiNET.ImPlotNative.ImPlot_BeginPlot(Byte* title_id, Byte* x_label, Byte* y_label, Vector2 size, ImPlotFlags flags, ImPlotAxisFlags x_flags, ImPlotAxisFlags y_flags, ImPlotAxisFlags y2_flags, ImPlotAxisFlags y3_flags)
at ImGuiNET.ImPlot.BeginPlot(String title_id, String x_label, String y_label) in S:\Dev\github\ImGui.NET\src\ImPlot.NET\Generated\ImPlot.gen.cs:line 377
at ImGuiNET.SampleProgram.XNA.SampleGame.ImGuiLayout() in S:\Dev\github\ImGui.NET\src\ImGui.NET.SampleProgram.XNA\SampleGame.cs:line 84
at ImGuiNET.SampleProgram.XNA.SampleGame.Draw(GameTime gameTime) in S:\Dev\github\ImGui.NET\src\ImGui.NET.SampleProgram.XNA\SampleGame.cs:line 63
at Microsoft.Xna.Framework.Game.DoDraw(GameTime gameTime)
at Microsoft.Xna.Framework.Game.Tick()
at Microsoft.Xna.Framework.SdlGamePlatform.RunLoop()
at Microsoft.Xna.Framework.Game.Run(GameRunBehavior runBehavior)
at ImGuiNET.SampleProgram.XNA.Program.Main(String[] args) in S:\Dev\github\ImGui.NET\src\ImGui.NET.SampleProgram.XNA\Program.cs:line 7

I have just added thoose 2 lines to the XNA SampleGame on line 84

ImPlot.BeginPlot("Testplot", "x", "y");
ImPlot.EndPlot();

I've also tested Implot.CreateContext() and implot.SetImGuiContext() (inside ImguiRenderer ctor), doesn't work.

Do i miss something obvious here?

//cbaal83

TillAlex · 2020-11-30T09:15:47Z

Just tested the same and it works. Found two potential problems you could be running into:

I had to add the following to ImGuiRenderer after line 46:
IntPtr implotContext = ImPlot.CreateContext(); ImPlot.SetCurrentContext(implotContext); ImPlot.SetImGuiContext(context);
Be sure to use the cimgui.dll I provided. It tends to be replaced every time you build.

cbaal83 · 2020-11-30T09:32:56Z

Yep, i haven't done all three together. It's working now :).
Will test now! Thanks!
//cbaal

cbaal83 · 2020-11-30T10:53:48Z

Ok, quick question:
How iam supposed to pass in the values? All of them accepting a "ref float" value, which should be an array.
I tried passing a pointer to it, still doesnt work like so:

var min = typed.Min(x => x.Price);
var max = typed.Max(x => x.Price);
var avg = typed.Average(x => x.Price);
float[] value = new float[] { min, max, (float)avg };
unsafe
{
     fixed (float* ptr = value)
     {
            ImPlot.PlotBars("values", ref *ptr, 3);
      }
}

cbaal83 · 2020-11-30T11:39:55Z

Another issue:
Even if i pass in a single value like so:
ImPlot.PlotBars("min", ref min, 1);
Value of that bar is always 1 (min is NOT 1 ;) ).

I have the feel iam doing something wrong here :D.
I've checked the original demos, but can't find anything obvious wrong..

//cbaal

cbaal83 · 2020-11-30T11:48:59Z

I feel stupid now, chart wasn't zoomed out...
Sorry!

TillAlex · 2020-11-30T13:19:52Z

I can not check at the moment if this works, but you can try

ImPlot.PlotBars("values", ref value[0], 3);

cbaal83 · 2020-11-30T13:46:45Z

Both works, the safe and unsafe way.
I was missing the following piece:
ImPlot.SetNextPlotLimits(0, 3, 0, _chartMax);

Which needs to be called before any Implot.BeginPlot
So far it works perfect (some api stuff is there which i dont like, but that is not the fault of this wrapper :) )

Thanks!

bootzin · 2020-11-30T21:12:45Z

Do these work with the docking/viewport branch of imgui?

cbaal83 · 2020-12-01T09:17:28Z

@TillAlex
Im missing some functions which are defined in implot_internal.h:

Implot.BeginItem
Implot.EndItem,
Implot.GetCurrentItem,
Implot.FitThisFrame,
Implot.FitPoint

which are necessary for custom graphs.

Any chance you add them?
//cbaal

TillAlex · 2020-12-01T09:58:31Z

@cbaal83 As far as I understand cimplot does not wrap the internal api of implot. @sonoro1234 Is this correct?

sonoro1234 · 2020-12-01T10:01:30Z

@cbaal83 As far as I understand cimplot does not wrap the internal api of implot. @sonoro1234 Is this correct?

Yes, only imgui_internal is wrapped.

cbaal83 · 2020-12-01T10:25:13Z

@sonoro1234
Any chance implot_internal will be added?

sonoro1234 · 2020-12-01T11:41:27Z

https://github.com/cimgui/cimplot/tree/internal just added
Main problem for using it is time_t being long in 32bits and long long in 64bits (with mingw-w64)

Main problem for compiling is

CMakeFiles\cimgui_glfw.dir/objects.a(cimplot.cpp.obj):cimplot.cpp:(.text+0x48f3): undefined reference to `ImPlot::LabelT
ickTime(ImPlotTick&, ImGuiTextBuffer&, ImPlotTime const&, ImPlotDateTimeFmt)'
CMakeFiles\cimgui_glfw.dir/objects.a(cimplot.cpp.obj):cimplot.cpp:(.text+0x49db): undefined reference to `ImPlot::AddTic
ksTime(ImPlotRange const&, int, ImPlotTickCollection&)'

I dont know why (LabelTickTime is inlined but AddTickTime is not inlined)
@epezent Any idea?

in implot.cpp
void AddTicksTime(const ImPlotRange& range, float plot_width, ImPlotTickCollection& ticks)
in implot_internal
IMPLOT_API void AddTicksTime(const ImPlotRange& range, int nMajor, ImPlotTickCollection& ticks);

so different signature

for LabelTickTime the cause seems to be inline in definition

Just pushed with

local cimgui_skipped = {
	 ImBufferWriter_Write = true,
	 ImPlot_LabelTickTime = true,
	 ImPlot_AddTicksTime = true
}

So that compilation succeds

Vivian-A · 2020-12-07T19:58:09Z

I took the precompiled binaries from your post earlier, where they're seperate dlls. Should I compile them myself?

TillAlex · 2020-12-07T20:29:50Z

You do not have to compile them yourself, but you really have to make sure you are using the precompiled cimgui.dll and cimplot.dll. The compiler tends to replace cimgui.dll with the one from the repository during compilation.

Vivian-A · 2020-12-08T00:57:03Z

Alright, I got it working! Thank you all so much!

TillAlex · 2020-12-08T07:07:36Z

What was the problem? Wrong DLL?

Vivian-A · 2020-12-08T07:09:42Z

Yeah, wrong dll. I had forgotten to replace it. Took some more tweaking with the Unity ImGui package I was using after that, but I've never been so happy to see a graph in my life. Thanks a ton for this PR man, truly appreciated!

freakbyte · 2021-01-08T20:01:59Z

Any progress on this?
tables was just merged into imgui master branch, seems like a good time to upgrade :>
Thank you for all your work, this is awesome!

bootzin · 2021-02-24T00:54:55Z

Hey guys
Just an update on this: Nelarius updated imnodes recently to include the SetImGuiContext() function, so we should probably be able to merge this in now without too much trouble

sonoro1234 · 2021-03-15T09:05:54Z

cimplot wraps implot_internal by default now

sonoro1234 · 2021-03-15T09:33:09Z

Nelarius updated imnodes recently to include the SetImGuiContext()

cimnodes also regenerated

sonoro1234 · 2021-03-16T14:26:05Z

Cimgui 1.82 generated

TillAlex · 2021-03-17T22:10:37Z

Recent native libraries can be found in the AppVeyor build artifacts of ImGuiNET/ImGui.NET-nativebuild#3.

freakbyte · 2021-03-18T10:48:20Z

Awesome :D Thank you!

TillAlex · 2021-03-19T11:32:03Z

It seems that I took the non docking definitions.json. Will fix this later on....

freakbyte · 2021-03-19T11:49:09Z

Was just about to ask if you had it working with docking as well :)

TillAlex · 2021-03-19T19:07:23Z

Definitions for cimgui from docking_inter brach are used again. Just did a short test with docking enabled and it seems to work.

TillAlex · 2021-03-19T19:21:54Z

I switched my branch of ImGui.NET-nativebuild to cimgui master accidently. Now it's using docking_inter branch again. Here is the corresponding pull request:

ImGuiNET/ImGui.NET-nativebuild#3

The appveyor pipeline there generates working native libraries for windows and linux.

mellinoe · 2021-03-21T09:04:20Z

@TillAlex I've merged this with a few adjustments applied in follow-up commits. I have not pushed any official packages using this yet, but I'd like to do that soon for the core library, because it's overdue for an update.

EDIT: Just wanted to say that this is an awesome contribution, thanks again!

TillAlex · 2021-03-23T11:14:33Z

@mellinoe Thanks for merging!

viliwonka · 2021-04-07T12:44:31Z

Ok I red whole thread, but I am still confused - how do I get to include Implot (and others) into docking version?

If I understand, everything is available already, just binaries are missing?

I wish to make this available for Unity, normal docking Imgui is working already :).

viliwonka · 2021-04-07T17:37:56Z

Ok, got it working on Windows/Unity by downloading this repo: https://github.com/TillAlex/ImGui.NET-nativebuild/tree/additional_libraries and running build-native.cmd

TillAlex added 4 commits November 28, 2020 22:58

Preparing code generator for ImPlot, ImNodes and ImGuizmo code genera…

02a838f

…tion

Added ImPlot.NET, ImNodes.NET and ImGuizmo.NET projects and correspon…

0bf95cb

…ding definition files

Generated code files for ImPlot.NET, ImNodes.NET and ImGuizmo.NET

13ce5ec

Added ImPlot demo window to sample program

5f15fdf

mellinoe reviewed Nov 29, 2020

View reviewed changes

TillAlex added 3 commits November 29, 2020 23:55

Preparing for separate native libraries

3c14895

Setting ImGuiContext for ImPlot

7b26ec8

Added missing braces

d6f961f

Merge remote-tracking branch 'origin/master' into ImPlot_ImNodes_ImGu…

a5a66dd

…izmo_Integration # Conflicts: # src/ImGui.NET.SampleProgram/ImGui.NET.SampleProgram.csproj

Separate namespaces for generated projects

d2fe090

Update generated files

3db0d27

sneusse mentioned this pull request Feb 26, 2021

Is this project abandoned? #237

Closed

Updated to ImGui 1.82 and recent ImPlot, ImNodes and ImGuizmo

7ab250f

Using cimgui from docking_inter branch again

2d1fc76

mellinoe merged commit 2d1fc76 into ImGuiNET:master Mar 21, 2021

BlizzCrafter mentioned this pull request Mar 23, 2021

Sample Projects broken since ImGuizmo, imnodes, ImPlot merge to master #241

Closed

hinxx mentioned this pull request Mar 26, 2021

Implot v0.9 binding KinoxKlark/pyimgui#2

Open

erictuvesson mentioned this pull request Mar 31, 2021

Use ImNodes and ImGuizmo erictuvesson/CSG#15

Open

sonoro1234 mentioned this pull request Apr 2, 2021

Please add Implot, ImGuizmo and ImNode dlls to deps Folder #246

Closed

sonoro1234 mentioned this pull request Apr 11, 2021

Add ImGuizmo and ImGuiPlot to Nuget #247

Open

Vivian-A mentioned this pull request Jun 28, 2021

ImPlot support? psydack/uimgui#2

Closed

Integration of ImPlot, ImNodes and ImGuizmo #218

Integration of ImPlot, ImNodes and ImGuizmo #218

Conversation

TillAlex commented Nov 28, 2020 • edited Loading

mellinoe commented Nov 29, 2020

mellinoe left a comment

Choose a reason for hiding this comment

mellinoe Nov 29, 2020

Choose a reason for hiding this comment

mellinoe Nov 29, 2020

Choose a reason for hiding this comment

mellinoe Nov 29, 2020

Choose a reason for hiding this comment

TillAlex commented Nov 29, 2020

cbaal83 commented Nov 29, 2020 • edited Loading

TillAlex commented Nov 29, 2020

cbaal83 commented Nov 30, 2020

cbaal83 commented Nov 30, 2020

TillAlex commented Nov 30, 2020

cbaal83 commented Nov 30, 2020

cbaal83 commented Nov 30, 2020 • edited Loading

cbaal83 commented Nov 30, 2020

cbaal83 commented Nov 30, 2020

TillAlex commented Nov 30, 2020

cbaal83 commented Nov 30, 2020 • edited Loading

bootzin commented Nov 30, 2020

cbaal83 commented Dec 1, 2020

TillAlex commented Dec 1, 2020

sonoro1234 commented Dec 1, 2020 • edited Loading

cbaal83 commented Dec 1, 2020

sonoro1234 commented Dec 1, 2020 • edited Loading

Vivian-A commented Dec 7, 2020

TillAlex commented Dec 7, 2020 • edited Loading

Vivian-A commented Dec 8, 2020

TillAlex commented Dec 8, 2020

Vivian-A commented Dec 8, 2020

freakbyte commented Jan 8, 2021

bootzin commented Feb 24, 2021

sonoro1234 commented Mar 15, 2021

sonoro1234 commented Mar 15, 2021

sonoro1234 commented Mar 16, 2021

TillAlex commented Mar 17, 2021

freakbyte commented Mar 18, 2021

TillAlex commented Mar 19, 2021

freakbyte commented Mar 19, 2021

TillAlex commented Mar 19, 2021 • edited Loading

TillAlex commented Mar 19, 2021 • edited Loading

mellinoe commented Mar 21, 2021 • edited Loading

TillAlex commented Mar 23, 2021

viliwonka commented Apr 7, 2021

viliwonka commented Apr 7, 2021

TillAlex commented Nov 28, 2020 •

edited

Loading

cbaal83 commented Nov 29, 2020 •

edited

Loading

cbaal83 commented Nov 30, 2020 •

edited

Loading

cbaal83 commented Nov 30, 2020 •

edited

Loading

sonoro1234 commented Dec 1, 2020 •

edited

Loading

sonoro1234 commented Dec 1, 2020 •

edited

Loading

TillAlex commented Dec 7, 2020 •

edited

Loading

TillAlex commented Mar 19, 2021 •

edited

Loading

TillAlex commented Mar 19, 2021 •

edited

Loading

mellinoe commented Mar 21, 2021 •

edited

Loading