Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"client_id" is missing from ID token #106

Closed
lionick opened this issue May 31, 2024 · 4 comments
Closed

"client_id" is missing from ID token #106

lionick opened this issue May 31, 2024 · 4 comments
Assignees
@rohe

Comments

@lionick
Copy link
Contributor

lionick commented May 31, 2024 •
edited
Loading

Running my tests for PR #104 , I saw that one of them failed.
It is the test_token_exchange_change_client_id_token where expects to get ID token having a "client_id" claim.
But client_id claim is not there anymore.
Is this something that you changed in purpose?
@c00kiemon5ter
@lionick lionick mentioned this issue May 31, 2024
Merged
@c00kiemon5ter c00kiemon5ter mentioned this issue Jun 10, 2024
Merged
@rohe
Copy link
Contributor

rohe commented Jul 8, 2024 •
edited
Loading

Not changed on purpose (that I can remember) and I can't find the test you refer to.

Is it a test of your own ?

@lionick
Copy link
Contributor Author

lionick commented Jul 11, 2024

This is a test coming from OIDC Frontend.

@rohe
Copy link
Contributor

rohe commented Aug 7, 2024

Should be fixed by now! Can you verify that !
And if it's resolved can you accept the PR.

@lionick
Copy link
Contributor Author

lionick commented Aug 10, 2024 •
edited
Loading

The problem is solved.
So I close this issue and will approve the PR.

@lionick lionick closed this as completed Aug 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rohe rohe

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rohe @lionick