Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Response type handling #104

Merged
merged 15 commits into from
Aug 25, 2024
Merged

Response type handling #104

merged 15 commits into from
Aug 25, 2024

Conversation

rohe
Copy link
Contributor

@rohe rohe commented May 24, 2024

Updated to align with the official PAR RFC.
Enforce that an access code can only be used once.
Worked with handling client_id.
Added upstream_get to UserInfo classes.
Improved resilience.
Entity ID is the clients identifier. It may also have a client_id.

rohe added 7 commits May 24, 2024 10:05
Get all the info from a ReadOnlyListFile object.
Worked on getting the jwks_path
Access code can only be used once except for when its first use when it can be used to mint an access token, an refresh token and an ID token.
Added client_id parameter to the get_user_claims() method.
Make userinfo be part of the upstream chain.
Fixed tests accordingly
Prepare for general automatic registration.
@rohe rohe requested review from ctriant and lionick and removed request for ctriant May 24, 2024 08:14
@rohe rohe force-pushed the response_type_handling branch from 9af1a1e to 56c0c73 Compare May 24, 2024 09:40
@lionick
Copy link
Contributor

lionick commented May 31, 2024

Hi, I opened an issue about this PR. (#106)

…cted.

Less common DPoP setup when issuer och receiver doesn't exist in the same entity_type guise.
@lionick
Copy link
Contributor

lionick commented Jun 7, 2024

Running my tests after the last commit, I still have the issue (#106). All the other tests passed successfully.

@rohe rohe force-pushed the response_type_handling branch from b8a94f9 to f3d0bca Compare July 8, 2024 16:16
Copy link
Contributor

@lionick lionick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rohe rohe merged commit 0290fb0 into main Aug 25, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants