Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IcingaCheckTask::ScriptFunc(): print os facts #7819

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

IcingaCheckTask::ScriptFunc(): print os facts #7819

wants to merge 2 commits into from

Conversation

Al2Klimov
Copy link
Member

fixes #7751

@Al2Klimov Al2Klimov self-assigned this Feb 6, 2020
@Al2Klimov
Copy link
Member Author 

        "last_check_result": {
            "active": true,
            "check_source": "alexanders-mbp.int.netways.de",
            "command": "icinga",
            "execution_end": 1581006459.751401,
            "execution_start": 1581006459.748775,
            "exit_status": 0.0,
            "output": "Icinga 2 has been running for 803 milliseconds. Version: v2.11.0-481-g7271c740b; Platform: Mac OS X; Platform version: 10.15.2; Kernel: Darwin; Kernel version: 19.2.0; Architecture: x86_64",

@Al2Klimov Al2Klimov removed their assignment Feb 6, 2020
@Al2Klimov Al2Klimov marked this pull request as ready for review February 6, 2020 16:31
@Al2Klimov Al2Klimov requested a review from htriem February 6, 2020 16:31
@dnsmichi dnsmichi mentioned this pull request Feb 7, 2020
Draft
@Al2Klimov Al2Klimov added this to the 2.13.0 milestone Mar 17, 2020
@Al2Klimov Al2Klimov removed the request for review from htriem December 14, 2020 18:05
@Al2Klimov Al2Klimov modified the milestones: 2.13.0, 2.14.0 Jun 2, 2021
@Al2Klimov
Copy link
Member Author

@cla-bot check

@cla-bot cla-bot bot added the cla/signed label Aug 4, 2021
@Al2Klimov Al2Klimov added the enhancement New feature or request label Aug 10, 2021
@julianbrost julianbrost removed this from the 2.14.0 milestone Jan 23, 2023
@Al2Klimov Al2Klimov requested a review from yhabteab October 31, 2024 15:04
yhabteab
yhabteab reviewed Nov 7, 2024
View reviewed changes
Copy link
Member

@yhabteab yhabteab left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why does this information need to be part of this check? Does anybody request it? This would only unnecessarily clutter up the check output and the database for no reason.

@Al2Klimov Al2Klimov mentioned this pull request Nov 7, 2024
Open
@Al2Klimov Al2Klimov requested a review from oxzi January 22, 2025 10:54
oxzi
oxzi reviewed Jan 22, 2025
View reviewed changes
Copy link
Member

@oxzi oxzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase first to resolve the conflicts and to trigger the CI.

@Al2Klimov Al2Klimov force-pushed the feature/icinga-check-os-facts-7751 branch from 7271c74 to 162b902 Compare January 24, 2025 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yhabteab yhabteab yhabteab left review comments

@oxzi oxzi oxzi left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
cla/signed enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make OS facts available in the icinga check
4 participants
@Al2Klimov @oxzi @yhabteab @julianbrost