Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Document mail-{host,service}-notification -X option #10322

Merged
merged 1 commit into from
Jan 24, 2025

Conversation

yhabteab
Copy link
Member

fixes #10002

@yhabteab yhabteab added this to the 2.15.0 milestone Jan 24, 2025
@yhabteab yhabteab requested a review from oxzi January 24, 2025 10:34
@cla-bot cla-bot bot added the cla/signed label Jan 24, 2025
Copy link
Member

@oxzi oxzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good to me!

I have verified that all command arguments from the two NotificationCommands are now listed here. For the future, these two documentation tables may be reordered to match the order in the NotificationCommands to ease comparing.

@oxzi oxzi added the area/documentation End-user or developer help label Jan 24, 2025
@yhabteab
Copy link
Member Author

For the future, these two documentation tables may be reordered to match the order in the NotificationCommands to ease comparing.

I was thinking the same but also didn't want to mix required and optional arguments, i.e. first list required ones and then the optional args.

@yhabteab yhabteab enabled auto-merge January 24, 2025 11:22
@yhabteab yhabteab merged commit 8f12831 into master Jan 24, 2025
23 checks passed
@yhabteab yhabteab deleted the missing-x-for-mail-notification branch January 24, 2025 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation End-user or developer help cla/signed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing argument "-X" for ITL command mail-host-notification
2 participants