tools/win32/configure*.ps1: allow custom $CMAKE_ARGS (JSON array) #10312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Al2Klimov
added
enhancement
Al2Klimov
force-pushed
the
win-configure-cmake-opts
branch
from
fdc2b57 to
842fb79
Compare
Al2Klimov
force-pushed
the
win-configure-cmake-opts
branch
from
842fb79 to
4175a47
Compare
julianbrost
approved these changes
Jan 22, 2025
This was referenced Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #10309
No "complete whitespace quoting nightmare" (#10309 (comment))! 👍
Tests
On non-admin GitLab runner Windows service.
CMAKE_ARGSset to["-DCPACK_WIX_LIGHT_EXTRA_FLAGS=-sval"]: succeeds (https://git.icinga.com/packaging/windows-icinga2/-/pipelines/35380)👍