Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Contactgroup configuration #188

Merged
merged 20 commits into from
Jun 11, 2024
Merged

Contactgroup configuration #188

merged 20 commits into from
Jun 11, 2024

Conversation

sukhwinder33445
Copy link
Contributor

@sukhwinder33445 sukhwinder33445 commented May 22, 2024 •
edited
Loading

resolves #174

@cla-bot cla-bot bot added the cla/signed CLA is signed by all contributors of a PR label May 22, 2024
sukhwinder33445
sukhwinder33445 commented May 22, 2024
View reviewed changes
application/controllers/ContactGroupController.php Outdated Show resolved Hide resolved
application/controllers/ContactGroupController.php Outdated Show resolved Hide resolved
application/controllers/ContactGroupsController.php Outdated Show resolved Hide resolved
application/controllers/ContactGroupsController.php Outdated Show resolved Hide resolved
application/controllers/ContactGroupsController.php Outdated Show resolved Hide resolved
application/forms/ContactGroupForm.php Outdated Show resolved Hide resolved
application/forms/ContactGroupForm.php Outdated Show resolved Hide resolved
library/Notifications/Widget/MemberSuggestions.php Outdated Show resolved Hide resolved
library/Notifications/Widget/MemberSuggestions.php Outdated Show resolved Hide resolved
library/Notifications/Widget/MemberSuggestions.php Outdated Show resolved Hide resolved
sukhwinder33445
sukhwinder33445 commented May 22, 2024
View reviewed changes
application/forms/ContactGroupForm.php Outdated Show resolved Hide resolved
application/forms/ContactGroupForm.php Outdated Show resolved Hide resolved
@nilmerg nilmerg added this to the Beta milestone May 22, 2024
@nilmerg nilmerg added the enhancement New feature or improvement label May 22, 2024
@sukhwinder33445 sukhwinder33445 changed the title Usergroup configuration Contactrgroup configuration May 22, 2024
@sukhwinder33445 sukhwinder33445 changed the title Contactrgroup configuration Contactgroup configuration May 22, 2024
@sukhwinder33445 sukhwinder33445 force-pushed the feature/usergroup-configuration branch 3 times, most recently from 6fb71ec to 0e5e95d Compare May 23, 2024 12:25
@sukhwinder33445 sukhwinder33445 force-pushed the feature/usergroup-configuration branch from 0e5e95d to 5e25668 Compare May 23, 2024 12:37
@sukhwinder33445 sukhwinder33445 requested a review from raviks789 May 23, 2024 12:38
@sukhwinder33445 sukhwinder33445 force-pushed the feature/usergroup-configuration branch 8 times, most recently from 09bab70 to fab4512 Compare May 23, 2024 14:28
@sukhwinder33445 sukhwinder33445 requested a review from nilmerg May 24, 2024 07:43
nilmerg
nilmerg requested changes Jun 11, 2024
View reviewed changes
Copy link
Member

@nilmerg nilmerg left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Editing a previously empty group fails
  • The control lines don't align:
    image

application/forms/ContactGroupForm.php Show resolved Hide resolved
@sukhwinder33445 sukhwinder33445 requested a review from nilmerg June 11, 2024 14:14
nilmerg
nilmerg requested changes Jun 11, 2024
View reviewed changes
Copy link
Member

@nilmerg nilmerg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding a group without members doesn't work

@sukhwinder33445 sukhwinder33445 force-pushed the feature/usergroup-configuration branch from 0cc4e12 to 5f405d9 Compare June 11, 2024 15:03
@sukhwinder33445 sukhwinder33445 requested a review from nilmerg June 11, 2024 15:05
ncosta-ic and others added 20 commits June 11, 2024 17:09
@ncosta-ic @nilmerg
feat: add contact group configuration links
b44c22b
@ncosta-ic @nilmerg
fix: controller links
9cf0401
@ncosta-ic @nilmerg
feat: add contact group permission
c0ad0c7
@ncosta-ic @nilmerg
feat,fix: contact group configuration & references
466c92d
@sukhwinder33445 @nilmerg
Fix code style
6fe792b 
Add method return type
Fix indentation
Simplify code
@sukhwinder33445 @nilmerg
ContactGroupsController: Add $filter property and getter
c7704c1
@sukhwinder33445 @nilmerg
Simplify ContactGroupFrom and MemberSuggestions
fca5e6f 
- Remove superfluous fieldset element
- Remove superfluous `contact:` prefix from terms
- Add phpDoc
@sukhwinder33445 @nilmerg
Contactgroup: Add detail view and make contactgroup editable/removable
a7aa42c
@sukhwinder33445 @nilmerg
Remove cancel button from model
286c8fc
@sukhwinder33445 @nilmerg
ContactGroupController: Use Links instaance when redirecting
e051c5c
@sukhwinder33445 @nilmerg
ContactGroupForm: Drop termInput property
3f80a86 
Use method to get the termInput element and request.
@sukhwinder33445 @nilmerg
Use Links for form action with showCompact and _disableLayout p…
7682050 
…aram
@sukhwinder33445 @nilmerg
ContactGroupForm::addGroup: Fix return type and remove superfluous er…
c77bf5b 
…ror handeling
@sukhwinder33445 @nilmerg
ContactGroupsController::getTabs: Remove superfluous condition
9713801
@sukhwinder33445 @nilmerg
ContactGroupForm::fetchDbValues: Add HttpNotFoundException
548c2dc 
The HttpNotFound method exists in Controller, not in form.
@sukhwinder33445 @nilmerg
Links: Remove modal specific params
7231ce2 
Add them directly if required
@sukhwinder33445 @nilmerg
ContactGroupForm: Use given $db property for db connection
152f036
@sukhwinder33445 @nilmerg
Fix form success and remove PhpDoc for void return type
4e59346
@sukhwinder33445 @nilmerg
ContactForm::removeContact: Remove reference from `contactgroup_mem…
4c66253 
…ber` table
@sukhwinder33445 @nilmerg
ContactGroupForm: Make members field optional
bdaf57f
@nilmerg nilmerg force-pushed the feature/usergroup-configuration branch from 5f405d9 to bdaf57f Compare June 11, 2024 15:09
@nilmerg nilmerg merged commit 5da809e into main Jun 11, 2024
22 checks passed
@nilmerg nilmerg deleted the feature/usergroup-configuration branch June 11, 2024 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ncosta-ic ncosta-ic ncosta-ic left review comments

@nilmerg nilmerg nilmerg approved these changes

@raviks789 raviks789 raviks789 left review comments

Assignees

@sukhwinder33445 sukhwinder33445

@ncosta-ic ncosta-ic

Labels
cla/signed CLA is signed by all contributors of a PR enhancement New feature or improvement
Projects
None yet
Milestone
Beta
Development

Successfully merging this pull request may close these issues.

Contactgroup Configuration
4 participants
@sukhwinder33445 @nilmerg @raviks789 @ncosta-ic