Add Icinga states to replica set #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhoxhaa
force-pushed
the
add-icinga-states-to-replica-set
branch
2 times, most recently
from
4e22941 to
6fed648
Compare
lippserd
requested changes
May 24, 2024
There was a problem hiding this comment.
- Use the new
IcingaStatetype. - In strings use
ReplicaSetinstead ofReplica Set. - In strings also show namespace, i.e.
ReplicaSet namespace/name .... - In strings always show current and desired ration, i.e. '2 current / 7 desired'.
- For the warning state I would write something like "... number of available replicas is less than ..."
getIcingaStateshould be a function ofReplicatSetbe renamed toApplyIcingaStatewhereIcingaStateandIcingaStateReasonis set directly.
jhoxhaa
force-pushed
the
add-icinga-states-to-replica-set
branch
2 times, most recently
from
dd1c695 to
cc9d393
Compare
|
Also add a grace period of 5 minutes (i.e. created timestamp + 5 minutes > now) before switching to warning or critical. |
jhoxhaa
force-pushed
the
add-icinga-states-to-replica-set
branch
4 times, most recently
from
f8d53a9 to
250d545
Compare
|
And please add newlines before |
jhoxhaa
force-pushed
the
add-icinga-states-to-replica-set
branch
3 times, most recently
from
de53667 to
5c4df9b
Compare
lippserd
requested changes
Jun 3, 2024
jhoxhaa
force-pushed
the
add-icinga-states-to-replica-set
branch
from
5c4df9b to
51b7b34
Compare
lippserd
approved these changes
Jun 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.