Use icinga go library #163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace module packages with accordingly imports from the icinga-go-library except the database package. That will be replaced later.
Local package 'database' -> 'kdatabase' Local db 'db' -> 'kdb' IGL package 'igldatabase' -> 'database' IGL db 'db2' -> 'db'
lippserd
requested changes
Jan 15, 2025
pkg/database/cleanup.go
Outdated
| @@ -107,7 +107,7 @@ type cleanupWhere struct { | |||
| } | |||
|
|
|||
| func (db *Database) PeriodicCleanup(ctx context.Context, stmt CleanupStmt) error { | |||
| g, ctxCleanup := errgroup.WithContext(ctx) | |||
| g, _ := errgroup.WithContext(ctx) | |||
There was a problem hiding this comment.
Instead of unnecessarily creating an errgroup, we could simply do the following at the end of the function:
select {
case err := <-errs:
return err
case <-ctx.Done():
return ctx.Err()
}
pkg/database/features.go
Outdated
| return func(f *Features) { | ||
| f.onSuccess = fn | ||
| } | ||
| } | ||
|
|
||
| type ProcessBulk[T any] func(ctx context.Context, bulk []T) (err error) |
There was a problem hiding this comment.
Can't all of this replaced with OnSuccessSendTo?
lippserd
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace module packages with accordingly imports from the icinga-go-library to reduce code redundancy. An exception is the database package that will be replaced later.