Multi cluster #146
Merged
Multi cluster #146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhoxhaa
force-pushed
the
multi-cluster
branch
2 times, most recently
from
127c2d7 to
e95e761
Compare
jhoxhaa
force-pushed
the
multi-cluster
branch
from
e3446b4 to
54ff40e
Compare
jhoxhaa
force-pushed
the
multi-cluster
branch
2 times, most recently
from
bd82e38 to
bf9a72c
Compare
lippserd
requested changes
Nov 29, 2024
pkg/schema/v1/contracts.go
Outdated
|
|
||
| // ClusterUuidFromContext returns the uuid value of the cluster stored in ctx, if any: | ||
| // | ||
| // e, ok := ClusterUuidFromContext(ctx) |
pkg/schema/v1/contracts.go
Outdated
| // } | ||
| func ClusterUuidFromContext(ctx context.Context) types.UUID { | ||
| clusterUuid, ok := ctx.Value(clusterContextKey).(types.UUID) | ||
|
|
There was a problem hiding this comment.
Remove newline here and add one before the return.
pkg/schema/v1/contracts.go
Outdated
| @@ -116,6 +125,26 @@ func NewNullableString(s any) sql.NullString { | |||
| panic(fmt.Sprintf("invalid type %T", s)) | |||
| } | |||
|
|
|||
| // NewClusterUuidContext returns a new Context that carries this Cluster as value. | |||
pkg/schema/v1/contracts.go
Outdated
| @@ -10,24 +11,32 @@ import ( | |||
| "reflect" | |||
| ) | |||
|
|
|||
| // Private type to prevent collisions with other context keys | |||
| type contextKey string | |||
There was a problem hiding this comment.
I would move the whole context related stuff to pkg/cluster so that it is encapsulated.
pkg/schema/v1/contracts.go
Outdated
| type contextKey string | ||
|
|
||
| // clusterContextKey is the key for Cluster values in contexts. | ||
| var clusterContextKey = contextKey("cluster") |
There was a problem hiding this comment.
Please rename clusterContextKey to clusterUuidContextKey and use contextKey("cluster_uuid").
jhoxhaa
force-pushed
the
multi-cluster
branch
5 times, most recently
from
1e9cf01 to
07d1f90
Compare
jhoxhaa
force-pushed
the
multi-cluster
branch
2 times, most recently
from
2ac91f7 to
3e4acc7
Compare
…ndling - Add `clusterUuid` to the `Meta` struct and update the `ObtainMeta` method to set it. - Modify the `Resource` interface to require `clusterUuid` in the `Obtain` method.
jhoxhaa
force-pushed
the
multi-cluster
branch
from
3e4acc7 to
834fb17
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.