#334 refactor: FridgeUser toEntity 메소드 추가

IceButler · Jul 30, 2024 · 10ed2c0 · 10ed2c0
1 parent 14f6800
commit 10ed2c0
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 17 deletions.
diff --git a/src/main/java/com/example/icebutler_server/fridge/dto/request/AddFridgeReq.java b/src/main/java/com/example/icebutler_server/fridge/dto/request/AddFridgeReq.java
@@ -13,11 +13,11 @@
 @NoArgsConstructor
 @Schema(name = "냉장고 추가 요청 정보")
 public class AddFridgeReq {
-  @NotBlank
-  @Schema(description = "냉장고 이름", example = "우리집 냉장고")
-  private String fridgeName;
-  @Schema(description = "냉장고 설명", example = "우리집 냉장고입니다~")
-  private String fridgeComment;
-  @Schema(description = "냉장고 멤버 ID 리스트", example = "[ 1, 2 ]")
-  private List<Long> members;
+    @NotBlank
+    @Schema(description = "냉장고 이름", example = "우리집 냉장고")
+    private String fridgeName;
+    @Schema(description = "냉장고 설명", example = "우리집 냉장고입니다~")
+    private String fridgeComment;
+    @Schema(description = "냉장고 멤버 ID 리스트", example = "[ 1, 2 ]")
+    private List<Long> members;
 }
diff --git a/src/main/java/com/example/icebutler_server/fridge/entity/FridgeUser.java b/src/main/java/com/example/icebutler_server/fridge/entity/FridgeUser.java
@@ -41,6 +41,14 @@ public FridgeUser(User user, Fridge fridge, FridgeRole role) {
         this.role = role;
     }
 
+    public static FridgeUser toEntity(User user, Fridge fridge, FridgeRole fridgeRole) {
+        return FridgeUser.builder()
+                .fridge(fridge)
+                .user(user)
+                .role(fridgeRole)
+                .build();
+    }
+
     public void changeRoleToOwner(){
         this.role = FridgeRole.OWNER;
     }

diff --git a/src/main/java/com/example/icebutler_server/fridge/service/FridgeServiceImpl.java b/src/main/java/com/example/icebutler_server/fridge/service/FridgeServiceImpl.java
@@ -75,20 +75,12 @@ public Long addFridge(AddFridgeReq addFridgeReq, Long ownerId) {
                 .map(memberId -> {
                     User user = userRepository.findByIdAndIsEnable(memberId, true)
                             .orElseThrow(() -> new BaseException(NOT_FOUND_USER));
-                    return FridgeUser.builder()
-                            .fridge(fridge)
-                            .user(user)
-                            .role(FridgeRole.MEMBER)
-                            .build();
+                    return FridgeUser.toEntity(user, fridge, FridgeRole.MEMBER);
                 })
                 .collect(Collectors.toList());
 
         User owner = userRepository.findById(ownerId).orElseThrow(() -> new BaseException(NOT_FOUND_USER));
-        members.add(FridgeUser.builder()
-                .fridge(fridge)
-                .user(owner)
-                .role(FridgeRole.OWNER)
-                .build());
+        members.add(FridgeUser.toEntity(owner,fridge, FridgeRole.OWNER));
 
         fridgeUserRepository.saveAll(members);
         cartRepository.save(Cart.toEntity(fridge));