This repository has been archived by the owner on Jul 27, 2020. It is now read-only.
Script fixed #9
Open
Script fixed #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
November 8, 2013 22:09
Moved parameters parsing to top... elseway the parameter of this line were just completely ignored and replaced with default values.
$('#parallax1').parallax("10%", 1.5);
Now it works great!
Upgraded jQuery to 1.10 and the Parallax to 1.1.4
Added support parameter to set the initial vertical position of Backgrounds
|
👍 I was just about to do a pull request to fix this as well, glad you saved me the trouble. |
Small improvements
|
Anyone have a maintained branch? Perhaps @IanLunn could link to someone who took this over. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, i've fixed the main script and updated the example file and documentation file.
Before all parameters of .parallax(p1 , p2 , p3) was completely ignored and replaced at runtime with default values.
Now instead it works great. I've also upgraded example to jQuery 1.10.1
PS. i've added my name in the script and readme after your. tell me if this is a problem.
bye