Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TG Mirror] [NO GBP] Fixed a few more issues with fishing. [MDB IGNORE] #9

Closed
wants to merge 1 commit into from

Conversation

ffmirrorbot[bot]
Copy link

@ffmirrorbot ffmirrorbot bot commented Oct 12, 2023

Mirrored on Skyrat: ${this.url}
Original PR: (original url)

About The Pull Request

fix: Examining twice experiment handlers with an active fish-related experiment now gives a comprehensible, correctly spaced list of scanned species rather than something like "pufferfishguppyslimefishchasmchrab".
fix: No more "line snapped" balloon messages everytime the fishing minigame is over
fix: Getting to the Master level of the fishing skill now correctly gives you that slight helping hand to identify yet-to-be-caught fishes.

Why It's Good For The Game

Taking care of some issues I've noticed just yesterday.

Changelog

🆑 Ghommie
fix: Examining twice experiment handlers with an active fish-related experiment now gives a comprehensible, correctly spaced list of scanned species rather than something like "pufferfishguppyslimefishchasmchrab".
fix: No more "line snapped" balloon messages everytime the fishing minigame is over
fix: Getting to the Master level of the fishing skill now correctly gives you that slight helping hand to identify yet-to-be-caught fishes.
/:cl:

…(#24285)

* [NO GBP] Fixed a few more issues with fishing. (#78904)

## About The Pull Request
fix: Examining twice experiment handlers with an active fish-related
experiment now gives a comprehensible, correctly spaced list of scanned
species rather than something like "pufferfishguppyslimefishchasmchrab".
fix: No more "line snapped" balloon messages everytime the fishing
minigame is over
fix: Getting to the Master level of the fishing skill now correctly
gives you that slight helping hand to identify yet-to-be-caught fishes.

## Why It's Good For The Game
Taking care of some issues I've noticed just yesterday.

## Changelog

:cl:
fix: Examining twice experiment handlers with an active fish-related
experiment now gives a comprehensible, correctly spaced list of scanned
species rather than something like "pufferfishguppyslimefishchasmchrab".
fix: No more "line snapped" balloon messages everytime the fishing
minigame is over
fix: Getting to the Master level of the fishing skill now correctly
gives you that slight helping hand to identify yet-to-be-caught fishes.
/:cl:

* [NO GBP] Fixed a few more issues with fishing.

---------

Co-authored-by: Ghom <[email protected]>
@Iajret Iajret closed this Oct 17, 2023
@Iajret Iajret deleted the upstream-mirror-24285 branch October 17, 2023 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants