[TG Mirror] Reduces the average delay between random events, cleans up event subsystem code [MDB IGNORE] #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![ffmirrorbot[bot]](https://avatars.githubusercontent.com/in/391347?s=60&v=4){kind=small}
…vent subsystem code [MDB IGNORE] (#24378) * Reduces the average delay between random events, cleans up event subsystem code * Update events.dm * Update events.dm --------- Co-authored-by: Rhials <[email protected]> Co-authored-by: Bloop <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirrored on Skyrat: ${this.url}
Original PR: (original url)
About The Pull Request
Alright first thing's first --
frequency_lower = 3 minutes -> 2.5 minutesfrequency_upper = 10 minutes -> 7 minutesThere's also some autodocing/unsinglenamevaring of the events subsystem, and the event selection code has been moved to a pick_weight().
This should have no effect on summon events, since that sets the frequencies manually when triggered.
Why It's Good For The Game
The benign, fluffy events now heavily outweigh the truly destructive events in the pool. Even situationally destructive ones like the Supermatter Surge or Brand Intelligence provide players with a meaningful diversion to keep themselves occupied with.
Having more things going on, and more for players to do, is a good thing. Reducing the potentially lengthy delay between random events should accomplish this without increasing the amount of chaos between rounds.
Also, these values were changed 8 years ago, under the reasoning that "there are more random events now". We can safely say that there are even MORE random events now. I know changing something because it was changed in the past isn't a valid reason, but it's what set me down this road in the first place.
As a reminder, ghost antag events are handled through dynamic (unless dynamic is out of threat), meaning this won't seriously affect how frequently you see antags.
These values are, of course, subject to change in response to feedback, discussion, and maintainers yelling at me.
Changelog
🆑 Rhials
balance: Random event frequency has been adjusted to fire events more often.
code: The event subsystem has been prettied up with comments and longer variable names.
/:cl: