[TG Mirror] [NO GBP]Fixes plumbing for good(hopefully) & more reagent code [MDB IGNORE] #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![ffmirrorbot[bot]](https://avatars.githubusercontent.com/in/391347?s=60&v=4){kind=small}
…de [MDB IGNORE] (#24347) * [NO GBP]Fixes plumbing for good(hopefully) & more reagent code (#78947) 1. This should be the end of all problems related to plumbing and I swear if another issue popes up I'm goanna delete my GitHub account. Or to be more realistic just ping me and I'll be back :D - Fixes #78945 And this time I am **100%**(if I'm wrong then fuck me) sure that reagents will not flow in excess amounts into reaction chambers/synthesizers or whatever plumbing component you can think off. Reagents flowing in excess amounts is what caused the factory to grind to a halt as the components will stop processing if they detect excess amounts of reagents (which is why plunging them with a plunger would clear them of their reagents and help them resume processing again which obviously is not an ideal solution) Also, now it's no longer required to see reagent volumes in 4 decimal places so I rounded it back to just 2 places again so values like 0.999 or 1.001 will become just 1 again. Also plumbing reaction chamber was doing too much work so I fixed that. 2. Made defines for min & max ph. any change to ph values of any reagent will be confined between these values i.e., 0 & 14. Also converted some vars into defines. Using a variable makes sense if it's value changes but if it doesn't then just define it as a constant so you can save memory. Made synthesizer lists static to further save memory. 3. Significantly boosted the ph balancing mechanism for reaction chamber. You will be surprised. :cl: fix: plumbing setups should(hopefully) no longer grind to a halt nor will overflow with excess volume of reagents. code: created defines for min & max ph. Improved some reaction_reagent code. Made synthesizer dispensable reagent list values static to save memory. refactor: ph balancing mechanism for reaction chamber is significantly improved. Optimized it's code overall refactor: examining each individual reagent will display their results back to 2 decimal places again and not 4 for easy readability. /:cl: --------- Co-authored-by: Ghom <42542238+Ghommie@ users.noreply.github.com> * [NO GBP]Fixes plumbing for good(hopefully) & more reagent code --------- Co-authored-by: SyncIt21 <[email protected]> Co-authored-by: Ghom <42542238+Ghommie@ users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirrored on Skyrat: ${this.url}
Original PR: (original url)
About The Pull Request
This should be the end of all problems related to plumbing and I swear if another issue popes up I'm goanna delete my GitHub account. Or to be more realistic just ping me and I'll be back :D
And this time I am 100%(if I'm wrong then fuck me) sure that reagents will not flow in excess amounts into reaction chambers/synthesizers or whatever plumbing component you can think off.
Reagents flowing in excess amounts is what caused the factory to grind to a halt as the components will stop processing if they detect excess amounts of reagents (which is why plunging them with a plunger would clear them of their reagents and help them resume processing again which obviously is not an ideal solution)
Also, now it's no longer required to see reagent volumes in 4 decimal places so I rounded it back to just 2 places again so values like 0.999 or 1.001 will become just 1 again.
Also plumbing reaction chamber was doing too much work so I fixed that.
Made defines for min & max ph. any change to ph values of any reagent will be confined between these values i.e., 0 & 14. Also converted some vars into defines. Using a variable makes sense if it's value changes but if it doesn't then just define it as a constant so you can save memory. Made synthesizer lists static to further save memory.
Significantly boosted the ph balancing mechanism for reaction chamber. You will be surprised.
Changelog
🆑 SyncIt21
fix: plumbing setups should(hopefully) no longer grind to a halt nor will overflow with excess volume of reagents.
code: created defines for min & max ph. Improved some reaction_reagent code. Made synthesizer dispensable reagent list values static to save memory.
refactor: ph balancing mechanism for reaction chamber is significantly improved. Optimized it's code overall
refactor: examining each individual reagent will display their results back to 2 decimal places again and not 4 for easy readability.
/:cl: